Skip to content

Commit 0f9f518

Browse files
authored
Changes for release v19_1. (#511)
1 parent fb2f477 commit 0f9f518

File tree

150 files changed

+933
-324
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

150 files changed

+933
-324
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
33.0.0
2+
------
3+
- Compatibility with v19.1 of the API: https://developers.google.com/google-ads/api/docs/release-notes
4+
15
32.0.0
26
------
37
- Compatibility with v19 of the API: https://developers.google.com/google-ads/api/docs/release-notes

lib/google/ads/google_ads/interceptors/logging_interceptor.rb

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ class LoggingInterceptor < GRPC::ClientInterceptor
3737
customer_user_access.email_address|
3838
customer_user_access_invitation.email_address|
3939
change_event.user_email|
40-
feed.places_location_feed_data.email_address|
4140
local_services_lead.contact_details.phone_number|
4241
local_services_lead.contact_details.email|
4342
local_services_lead.contact_details.consumer_name|
@@ -229,18 +228,6 @@ def sanitize_message(message)
229228
sanitize_customer_user_access_invitation(message["operation"]["create"])
230229
end
231230
message
232-
elsif "Feed" == message_class
233-
# Sanitize sensitive fields specific to Feed get requests.
234-
message = clone_to_json(message)
235-
if message.include?("placesLocationFeedData") &&
236-
message["placesLocationFeedData"].include?("emailAddress")
237-
message["placesLocationFeedData"]["emailAddress"] = MASK_REPLACEMENT
238-
end
239-
message
240-
elsif "MutateFeedsRequest" == message_class
241-
# Sanitize sensitive fields when mutating a Feed.
242-
message = clone_to_json(message)
243-
sanitize_feeds_request(message)
244231
elsif "CreateCustomerClientRequest" == message_class
245232
# Sanitize sensitive fields when creating a CustomerClient.
246233
message = clone_to_json(message)
@@ -302,26 +289,6 @@ def sanitize_customer_user_access_invitation(message)
302289
message
303290
end
304291

305-
def sanitize_feeds_request(message)
306-
if message.include?("operations")
307-
message["operations"].each do |operation|
308-
if operation.include?("create")
309-
operation = operation["create"]
310-
elsif operation.include?("update")
311-
operation = operation["update"]
312-
else
313-
# Only create and update can contain sensitive fields.
314-
next
315-
end
316-
if operation.include?("placesLocationFeedData") &&
317-
operation["placesLocationFeedData"].include?("emailAddress")
318-
operation["placesLocationFeedData"]["emailAddress"] = MASK_REPLACEMENT
319-
end
320-
end
321-
end
322-
message
323-
end
324-
325292
def sanitize_field(object, path)
326293
split_path = path.split(".")
327294
target_field = split_path.last

lib/google/ads/google_ads/v19/common/ad_type_infos_pb.rb

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/common/metrics_pb.rb

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/common/segments_pb.rb

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/enums/ad_group_type_pb.rb

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/enums/ad_strength_action_item_type_pb.rb

Lines changed: 45 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/enums/ad_type_pb.rb

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/enums/advertising_channel_sub_type_pb.rb

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/google/ads/google_ads/v19/enums/asset_coverage_video_aspect_ratio_requirement_pb.rb

Lines changed: 45 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)