Skip to content

Commit 12530cc

Browse files
authored
Changes for release v18_0. (#500)
1 parent e42ff7f commit 12530cc

File tree

2,448 files changed

+116475
-106335
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

2,448 files changed

+116475
-106335
lines changed

.gitignore

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,3 +5,6 @@ lib/google/ads/google_ads/factories.rb
55
doc
66
.yardoc
77
lib/google/ads/google_ads/deprecation.rb
8+
9+
# For rbenv
10+
.ruby-version

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
31.0.0
2+
------
3+
- Compatibility with v18 of the API: https://developers.google.com/google-ads/api/docs/release-notes
4+
- Removed support for v15.
5+
16
30.0.0
27
------
38
- Compatibility with v17.1 of the API: https://developers.google.com/google-ads/api/docs/release-notes

codegen/spec/template_service_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
let(:gapic_client_class) {
88
double(
99
:klass,
10-
name: "Google::Ads::GoogleAds::V15::Services::GoogleAdsService::Client",
10+
name: "Google::Ads::GoogleAds::V17::Services::GoogleAdsService::Client",
1111
)
1212
}
1313

@@ -26,7 +26,7 @@
2626
# require returns true, so let's just stub it here
2727
allow(service).to receive(:require).with(path).and_return(true)
2828
stub_const(
29-
"Google::Ads::GoogleAds::V15::Services::GoogleAdsService::Service",
29+
"Google::Ads::GoogleAds::V17::Services::GoogleAdsService::Service",
3030
double(
3131
:fake_service_klass,
3232
rpc_descs: {Search: double(input: input)}

examples/account_management/create_customer.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,8 +57,6 @@ def create_customer(manager_customer_id)
5757
# [END create_customer]
5858

5959
if __FILE__ == $0
60-
PAGE_SIZE = 1000
61-
6260
options = {}
6361
# The following parameter(s) should be provided to run the example. You can
6462
# either specify these by changing the INSERT_XXX_ID_HERE values below, or on

examples/account_management/get_account_hierarchy.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,6 @@ def get_account_hierarchy(manager_customer_id, login_customer_id)
8484
response = google_ads_service.search(
8585
customer_id: cid,
8686
query: search_query,
87-
page_size: PAGE_SIZE,
8887
)
8988

9089
# Iterates over all rows in all pages to get all customer clients under
@@ -145,8 +144,6 @@ def print_account_hierarchy(customer_client, cid_to_children, depth)
145144
end
146145

147146
if __FILE__ == $PROGRAM_NAME
148-
PAGE_SIZE = 1000
149-
150147
options = {}
151148
# The following parameter(s) should be provided to run the example. You can
152149
# either specify these by changing the INSERT_XXX_ID_HERE values below, or on

examples/account_management/get_change_details.rb

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,6 @@ def get_change_details(customer_id)
6060
response = client.service.google_ads.search(
6161
customer_id: customer_id,
6262
query: query,
63-
# The page size is superfluous with the default limit set above, but it's
64-
# shown here since it's a good practice to use a reasonable page size when
65-
# you set a higher limit.
66-
page_size: PAGE_SIZE
6763
)
6864

6965
# Process the results and output changes.
@@ -140,8 +136,6 @@ def get_value_from_path(path, object)
140136
# [END get_change_details]
141137

142138
if __FILE__ == $PROGRAM_NAME
143-
PAGE_SIZE = 1000
144-
145139
options = {}
146140
# The following parameter(s) should be provided to run the example. You can
147141
# either specify these by changing the INSERT_XXX_ID_HERE values below, or on

examples/account_management/get_change_summary.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@ def get_change_summary(customer_id)
5151
response = client.service.google_ads.search(
5252
customer_id: customer_id,
5353
query: query,
54-
page_size: PAGE_SIZE
5554
)
5655

5756
# Process the results.
@@ -79,8 +78,6 @@ def get_change_summary(customer_id)
7978
# [END get_change_summary]
8079

8180
if __FILE__ == $PROGRAM_NAME
82-
PAGE_SIZE = 1000
83-
8481
options = {}
8582
# The following parameter(s) should be provided to run the example. You can
8683
# either specify these by changing the INSERT_XXX_ID_HERE values below, or on

examples/account_management/list_accessible_customers.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,6 @@ def list_accessible_customers()
4040
# [END list_accessible_customers]
4141

4242
if __FILE__ == $0
43-
PAGE_SIZE = 1000
44-
4543
begin
4644
list_accessible_customers()
4745
rescue Google::Ads::GoogleAds::Errors::GoogleAdsError => e

examples/advanced_operations/add_ad_customizer.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -164,10 +164,6 @@ def create_ad_with_customizations(client, customer_id, ad_group_id,
164164
# [END add_ad_customizer_3]
165165

166166
if __FILE__ == $0
167-
# We're doing only searches by resource_name in this example,
168-
# we can set page size = 1.
169-
PAGE_SIZE = 1;
170-
171167
options = {}
172168
# Running the example with -h will print the command line usage.
173169

examples/advanced_operations/find_and_remove_criteria_from_shared_set.rb

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,6 @@ def find_and_remove_criteria_from_shared_set(customer_id, campaign_id)
4141
response = ga_service.search(
4242
customer_id: customer_id,
4343
query: query,
44-
page_size: PAGE_SIZE,
4544
)
4645

4746
response.each do |row|
@@ -62,7 +61,6 @@ def find_and_remove_criteria_from_shared_set(customer_id, campaign_id)
6261
response = ga_service.search(
6362
customer_id: customer_id,
6463
query: query,
65-
page_size: PAGE_SIZE,
6664
)
6765

6866
response.each do |row|
@@ -92,7 +90,6 @@ def find_and_remove_criteria_from_shared_set(customer_id, campaign_id)
9290
end
9391

9492
if __FILE__ == $PROGRAM_NAME
95-
PAGE_SIZE = 1000
9693

9794
options = {}
9895
# The following parameter(s) should be provided to run the example. You can

0 commit comments

Comments
 (0)