[Feature Request] Rename initWithInt: to a more unique name to avoid possible name collision

[stuartmorgan-g]

This file is extremely dangerous, as it does does not follow Apple's explicit guidance on prefixing in shared code, in particular the "Always Use a Prefix for Method Names in Categories on Framework Classes" section.

initWithInt: is an extremely generic name, and method names in Obj-C must be unique across the entire compiled application. This means that if any other plugin anywhere in the ecosystem has the same problem, there will be a collision and one of the implementations will be chosen arbitrarily at runtime if an application includes both plugins. If it doesn't do exactly the same thing that this one does, the result will be undefined behavior in whichever is calling the version that does not behave as expected.

This extension needs to follow the standard convention of being someuniqueprefix_initWithInt:. Also, that prefix should really not be flt, nor should the extension name (FLTNSStringExtension) use the FLT prefix, since FLT is used by the Flutter team, and so this name is also subject to collision with code this project does not control. The project should pick its own unique prefix, and use that for both the extension name and the method name.

[malandr2]

Hi @stuartmorgan-g, thanks for pointing this out. Because changing the method is a breaking change, we will update the method name to a unique prefix such as gma_initWithInt: in the next major release.

@LTPhantom see https://developer.apple.com/library/archive/documentation/Cocoa/Conceptual/ProgrammingWithObjectiveC/CustomizingExistingClasses/CustomizingExistingClasses.html#//apple_ref/doc/uid/TP40011210-CH6-SW4 for guidance

[stuartmorgan-g]

@malandr2 Are you expecting clients of this plugin to be directly calling your native code? Usually plugins only consider the Dart API part of the public API surface.

[malandr2]

@stuartmorgan-g because we have to make a change in the .h file as well, it is considered exposed. The next release will most likely be our major 8.0.0 release so this change will be done on schedule :)