Skip to content

Commit 4e8bc01

Browse files
committed
remove character limit validation on event parameter values
1 parent f66aecd commit 4e8bc01

File tree

4 files changed

+0
-94
lines changed

4 files changed

+0
-94
lines changed

src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.spec.ts

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -43,31 +43,4 @@ describe("customSchema", () => {
4343

4444
expect(validator.isValid(validInput)).toEqual(false)
4545
})
46-
47-
test("allows session_id to exceed 100 characters", () => {
48-
const longString = "a".repeat(101)
49-
const validInput = { session_id: longString }
50-
51-
let validator = new Validator(customSchema)
52-
53-
expect(validator.isValid(validInput)).toEqual(true)
54-
})
55-
56-
test("allows session_number to exceed 100 characters", () => {
57-
const longString = "a".repeat(101)
58-
const validInput = { session_number: longString }
59-
60-
let validator = new Validator(customSchema)
61-
62-
expect(validator.isValid(validInput)).toEqual(true)
63-
})
64-
65-
test("does not allow other parameter values to exceed 100 characters", () => {
66-
const longString = "a".repeat(101)
67-
const invalidInput = { other_param: longString }
68-
69-
let validator = new Validator(customSchema)
70-
71-
expect(validator.isValid(invalidInput)).toEqual(false)
72-
})
7346
})

src/components/ga4/EventBuilder/ValidateEvent/schemas/eventTypes/custom.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -13,12 +13,6 @@ export const customSchema = {
1313
"type": "object",
1414
"required": [],
1515
"maxProperties": 25,
16-
"patternProperties": {
17-
"^(session_id|session_number)$": {},
18-
"^(?!(session_id|session_number)$).*$": {
19-
"maxLength": 100
20-
}
21-
},
2216
"propertyNames": {
2317
"pattern": "^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
2418
"maxLength": 40

src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.spec.ts

Lines changed: 0 additions & 55 deletions
This file was deleted.

src/components/ga4/EventBuilder/ValidateEvent/schemas/schemaBuilder.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,6 @@ export const buildEvents = () => {
3737
"^(?!ga_|google_|firebase_)[A-Za-z][A-Za-z0-9_]*$",
3838
"maxLength":
3939
40
40-
},
41-
"patternProperties": {
42-
"^(session_id|session_number)$": {},
43-
"^(?!(session_id|session_number)$).*$": {
44-
"maxLength": 100
45-
}
4640
}
4741
}
4842
}

0 commit comments

Comments
 (0)