Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

Commit 00ead61

Browse files
renovate[bot]yoshi-automation
authored andcommitted
fix(deps): update dependency gcp-metadata to v1
fix(deps): update dependency gcp-metadata to v1 This PR contains the following updates: | Package | Type | Update | Change | References | |---|---|---|---|---| | gcp-metadata | dependencies | major | `^0.9.0` -> `^1.0.0` | [source](https://togithub.com/googleapis/gcp-metadata) | --- ### Release Notes <details> <summary>googleapis/gcp-metadata</summary> ### [`v1.0.0`](https://togithub.com/googleapis/gcp-metadata/blob/master/CHANGELOG.md#v100) [Compare Source](https://togithub.com/googleapis/gcp-metadata/compare/v0.9.3...v1.0.0) 02-14-2019 16:00 PST ##### Bug Fixes - fix: ask gaxios for text and not json ([#&#8203;152](https://togithub.com/googleapis/gcp-metadata/pull/152)) ##### Documentation - docs: update links in contrib guide ([#&#8203;168](https://togithub.com/googleapis/gcp-metadata/pull/168)) - docs: add lint/fix example to contributing guide ([#&#8203;160](https://togithub.com/googleapis/gcp-metadata/pull/160)) ##### Internal / Testing Changes - build: use linkinator for docs test ([#&#8203;166](https://togithub.com/googleapis/gcp-metadata/pull/166)) - chore(deps): update dependency [@&#8203;types/tmp](https://togithub.com/types/tmp) to v0.0.34 ([#&#8203;167](https://togithub.com/googleapis/gcp-metadata/pull/167)) - build: create docs test npm scripts ([#&#8203;165](https://togithub.com/googleapis/gcp-metadata/pull/165)) - test: run system tests on GCB ([#&#8203;157](https://togithub.com/googleapis/gcp-metadata/pull/157)) - build: test using [@&#8203;grpc/grpc-js](https://togithub.com/grpc/grpc-js) in CI ([#&#8203;164](https://togithub.com/googleapis/gcp-metadata/pull/164)) - chore: move CONTRIBUTING.md to root ([#&#8203;162](https://togithub.com/googleapis/gcp-metadata/pull/162)) - chore(deps): update dependency gcx to v0.1.1 ([#&#8203;159](https://togithub.com/googleapis/gcp-metadata/pull/159)) - chore(deps): update dependency gcx to v0.1.0 ([#&#8203;158](https://togithub.com/googleapis/gcp-metadata/pull/158)) - chore(deps): update dependency gcx to v0.0.4 ([#&#8203;155](https://togithub.com/googleapis/gcp-metadata/pull/155)) - chore(deps): update dependency googleapis to v37 ([#&#8203;156](https://togithub.com/googleapis/gcp-metadata/pull/156)) - build: ignore googleapis.com in doc link check ([#&#8203;153](https://togithub.com/googleapis/gcp-metadata/pull/153)) - build: check broken links in generated docs ([#&#8203;149](https://togithub.com/googleapis/gcp-metadata/pull/149)) - chore(build): inject yoshi automation key ([#&#8203;148](https://togithub.com/googleapis/gcp-metadata/pull/148)) </details> --- ### Renovate configuration :date: **Schedule**: "after 9am and before 3pm" (UTC). :vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied. :recycle: **Rebasing**: Whenever PR is stale, or if you modify the PR title to begin with "`rebase!`". :no_bell: **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- renovate-rebase -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/marketplace/renovate). View repository job log [here](https://renovatebot.com/dashboard#googleapis/cloud-debug-nodejs). #641 automerged by dpebot
1 parent f79c83c commit 00ead61

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@
6868
"console-log-level": "^1.4.0",
6969
"extend": "^3.0.1",
7070
"findit2": "^2.2.3",
71-
"gcp-metadata": "^0.9.0",
71+
"gcp-metadata": "^1.0.0",
7272
"lodash.pickby": "^4.6.0",
7373
"p-limit": "^2.0.0",
7474
"pify": "^4.0.1",

test/nocks.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17+
import * as gcpMetadata from 'gcp-metadata';
1718
import * as nock from 'nock';
1819

1920
// In the future _=>true.
@@ -48,14 +49,14 @@ export function register(validator?: Validator): nock.Scope {
4849
}
4950

5051
export function projectId(reply: string): nock.Scope {
51-
return nock('http://metadata.google.internal')
52+
return nock(gcpMetadata.HOST_ADDRESS)
5253
.get('/computeMetadata/v1/project/project-id')
5354
.once()
5455
.reply(200, reply);
5556
}
5657

5758
export function metadataInstance(): nock.Scope {
58-
return nock('http://metadata.google.internal/')
59+
return nock(gcpMetadata.HOST_ADDRESS)
5960
.get('/computeMetadata/v1/instance')
6061
.replyWithError({code: 'ENOTFOUND', message: 'nocked request'});
6162
}

test/test-debuglet.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
import * as assert from 'assert';
1818
import * as fs from 'fs';
19+
import * as gcpMetadata from 'gcp-metadata';
1920
import * as path from 'path';
2021
import * as proxyquire from 'proxyquire';
2122

@@ -728,7 +729,7 @@ describe('Debuglet', () => {
728729
return Promise.resolve(true);
729730
};
730731
const clusterScope =
731-
nock('http://metadata.google.internal')
732+
nock(gcpMetadata.HOST_ADDRESS)
732733
.get('/computeMetadata/v1/instance/attributes/cluster-name')
733734
.once()
734735
.reply(200, 'cluster-name-from-metadata');

0 commit comments

Comments
 (0)