chore: update nock to v11 (#764)

Author: DominicKramer

package.json

@@ -72,7 +72,6 @@
     "@types/mkdirp": "^0.5.1",
     "@types/mocha": "^5.0.0",
     "@types/ncp": "^2.0.1",
-    "@types/nock": "^10.0.0",
     "@types/node": "~10.14.0",
     "@types/proxyquire": "^1.3.28",
     "@types/semver": "^6.0.0",
@@ -86,7 +85,7 @@
     "mkdirp": "^0.5.1",
     "mocha": "^6.1.4",
     "ncp": "^2.0.0",
-    "nock": "^10.0.0",
+    "nock": "^11.0.0",
     "nyc": "^14.0.0",
     "post-install-check": "0.0.1",
     "proxyquire": "^2.0.0",

test/test-controller.ts

@@ -249,11 +249,17 @@ describe('Controller API', () => {
         id: 'breakpoint-0',
         location: {path: 'foo.js', line: 99},
       } as stackdriver.Breakpoint;
+      // A cast for the second argument to put() is necessary for nock 11
+      // because the type definitions state that the second argument cannot
+      // be an Object even though the nock code itself seems to handle an
+      // Object.  Further, the tests pass when using the cast.
+      // This issue is being tracked in the nock repo at
+      // https://github.com/nock/nock/issues/1731.
       const scope = nock(url)
         .put(api + '/debuggees/fake-debuggee/breakpoints/breakpoint-0', {
           debuggeeId: 'fake-debuggee',
           breakpoint,
-        })
+        } as {})
         .reply(200, {
           kind: 'debugletcontroller#updateActiveBreakpointResponse',
         });

test/test-debuglet.ts

@@ -71,7 +71,7 @@ function verifyBreakpointRejection(
   body: {breakpoint: stackdriver.Breakpoint}
 ) {
   const status = body.breakpoint.status;
-  const hasCorrectDescription = status!.description.format.match(re);
+  const hasCorrectDescription = !!status!.description.format.match(re);
   return status!.isError && hasCorrectDescription;
 }