chore: address linter issues (#1356)

Author: JustinBeckwith

src/plugins/plugin-mongoose.ts

@@ -12,6 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
+// eslint-disable-next-line node/no-extraneous-import
 import * as mongooseTypes from 'mongoose';
 import {PluginTypes} from '..';
 

test/plugins/test-plugins-interop-mongo-express.ts

@@ -27,13 +27,11 @@ import {describe, it, before} from 'mocha';
 let server;
 
 describe('mongodb + express', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  let agent;
   let oldWarn;
   let mongoose;
   let express;
   before(() => {
-    agent = require('../../..').start({projectId: '0'});
+    require('../../..').start({projectId: '0'});
     express = require('./fixtures/express4');
     mongoose = require('./fixtures/mongoose4');
     oldWarn = common.replaceWarnLogger(error => {

test/plugins/test-plugins-multi-version.ts

@@ -23,13 +23,11 @@ import {describe, it, before, after} from 'mocha';
 const common = require('./common' /*.js*/);
 
 describe('multiple instrumentations of the same module', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  let agent;
   let clientv0;
   let clientv2;
 
   before(() => {
-    agent = require('../../..').start({
+    require('../../..').start({
       projectId: '0',
       enhancedDatabaseReporting: true,
       samplingRate: 0,

test/plugins/test-trace-http.ts

@@ -203,10 +203,10 @@ for (const nodule of Object.keys(servers) as Array<keyof typeof servers>) {
           fn: async () => {
             const waitForResponse = new WaitForResponse();
             http.get({port, rejectUnauthorized: false}, res => {
-              // eslint-disable-next-line @typescript-eslint/no-unused-vars
               let result = '';
               const writable = new stream.Writable();
               writable._write = (chunk, encoding, next) => {
+                // eslint-disable-next-line @typescript-eslint/no-unused-vars
                 result += chunk;
                 next();
               };

test/plugins/test-trace-mongoose-async-await.ts

@@ -14,6 +14,7 @@
 
 import * as assert from 'assert';
 import {it, before, after, afterEach} from 'mocha';
+// eslint-disable-next-line node/no-extraneous-import
 import * as mongooseTypes from 'mongoose';
 
 import * as traceTestModule from '../trace';

test/plugins/test-trace-mongoose.ts

@@ -26,11 +26,9 @@ import {describe, it, before, beforeEach, afterEach} from 'mocha';
 import * as assert from 'assert';
 
 describe('mongoose integration tests', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  let agent;
   let Simple;
   before(() => {
-    agent = require('../../..').start({
+    require('../../..').start({
       projectId: '0',
       samplingRate: 0,
     });

test/plugins/test-trace-pg.ts

@@ -26,13 +26,11 @@ const pgVersions = []; // ['6', '7'];
 pgVersions.forEach(pgVersion => {
   describe(`test-trace-pg (v${pgVersion})`, () => {
     let pg;
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    let traceApi;
     let pool;
     let client;
     let releaseClient;
     before(() => {
-      traceApi = require('../../..').start({
+      require('../../..').start({
         projectId: '0',
         samplingRate: 0,
         enhancedDatabaseReporting: true,

test/plugins/test-trace-redis.ts

@@ -29,11 +29,8 @@ import * as assert from 'assert';
 import {describe, it, before, beforeEach, afterEach} from 'mocha';
 
 describe('redis', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  let agent;
-
   before(() => {
-    agent = require('../../..').start({
+    require('../../..').start({
       projectId: '0',
       samplingRate: 0,
       enhancedDatabaseReporting: true,

test/test-mysql-pool.ts

@@ -22,11 +22,9 @@ import {describe, it, before} from 'mocha';
 // hapi 13 and hapi-plugin-mysql uses const
 if (semver.satisfies(process.version, '>=4')) {
   describe('test-trace-mysql', () => {
-    // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    let agent;
     let Hapi;
     before(() => {
-      agent = require('../..').start({
+      require('../..').start({
         projectId: '0',
         samplingRate: 0,
         enhancedDatabaseReporting: true,
@@ -56,9 +54,9 @@ if (semver.satisfies(process.version, '>=4')) {
           server.start(err => {
             assert(!err);
             http.get({port: common.serverPort}, res => {
-              // eslint-disable-next-line @typescript-eslint/no-unused-vars
               let result = '';
               res.on('data', data => {
+                // eslint-disable-next-line @typescript-eslint/no-unused-vars
                 result += data;
               });
               res.on('end', () => {

test/test-plugins-no-project-num.ts

@@ -18,14 +18,12 @@ import {describe, before, after, it} from 'mocha';
 let write;
 
 describe('test-plugins-no-project-num', () => {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
-  let agent;
   let savedProject;
 
   before(() => {
     savedProject = process.env.GCLOUD_PROJECT;
     delete process.env.GCLOUD_PROJECT;
-    agent = require('../..').start();
+    require('../..').start();
   });
 
   after(() => {