Skip to content

Commit 7efbcd6

Browse files
committed
Final bit of feedback
1 parent 419ecbb commit 7efbcd6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

tests/unit/schema/test_api.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2773,8 +2773,8 @@ def test_python_settings_selective_gapic_nonexistent_method_raises_error():
27732773

27742774
def test_python_settings_selective_gapic_version_mismatch_method_raises_error():
27752775
"""
2776-
Test that `ClientLibrarySettingsError` is raised when there are nonexistent methods in
2777-
`client_pb2.ClientLibrarySettings.PythonSettings.CommonSettings.SelectiveGapicGeneration`.
2776+
Test that `ClientLibrarySettingsError` is raised when a method listed for selective generation
2777+
exists only in a different version of the library.
27782778
"""
27792779
client_library_settings = [
27802780
client_pb2.ClientLibrarySettings(
@@ -2892,8 +2892,8 @@ def test_selective_gapic_api_build():
28922892

28932893
# Establish that the API has the data expected.
28942894
assert isinstance(api_schema, api.API)
2895-
assert len(api_schema.all_protos) == 3
2896-
assert len(api_schema.protos) == 2
2895+
assert len(api_schema.all_protos) == 3 # foo.proto, common.proto, dep.proto
2896+
assert len(api_schema.protos) == 2 # foo.proto, common.proto
28972897

28982898
assert 'google.dep.ImportedMessage' not in api_schema.messages
28992899
assert 'google.example.v1.Foo' in api_schema.messages
@@ -3174,7 +3174,7 @@ def test_selective_gapic_api_build_remove_unnecessary_proto_files():
31743174
assert 'bar.proto' not in api_schema.protos
31753175
assert 'bar_common.proto' not in api_schema.protos
31763176

3177-
# Check that the sub-packages have been completely pruned are excluded from generation,
3177+
# Check that the sub-packages that have been completely pruned are excluded from generation,
31783178
# but the ones that have only been partially pruned will still be appropriately included.
31793179
assert 'foo_common' in api_schema.subpackages
31803180
sub = api_schema.subpackages['foo_common']

0 commit comments

Comments
 (0)