-
Notifications
You must be signed in to change notification settings - Fork 49
Open
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Description
I was trying to include a new schema/ proto file in #1573 (and everything worked locally) but the GitHub presubmits kept failing unless the corresponding generated pb.go file was included in the PR.
I believe the intent is for the pb.go files to not need to be included in PRs, so we should make it clear how to do that while getting presubmits to pass. If we do need to include the generated files in PRs, we should clarify that.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns.Error or flaw in code with unintended results or allowing sub-optimal usage patterns.