Skip to content
This repository was archived by the owner on Nov 18, 2025. It is now read-only.

Commit 87ca2ad

Browse files
refactor: enable noImplicitThis in the tsconfig (#347)
1 parent 0083e85 commit 87ca2ad

File tree

4 files changed

+8
-10
lines changed

4 files changed

+8
-10
lines changed

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,20 +56,20 @@
5656
"typescript": "~3.1.5"
5757
},
5858
"scripts": {
59-
"codecov": "istanbul test ./node_modules/mocha/bin/_mocha -- build/test --reporter spec --slow 500 && ./node_modules/codecov/bin/codecov",
59+
"codecov": "nyc mocha build/test --reporter spec --slow 500 && codecov",
6060
"docs": "echo no docs 📗",
6161
"gen-parser": "pegjs lib/path_template_parser.pegjs",
6262
"test": "npm run test-only",
63-
"test-only": "istanbul test ./node_modules/mocha/bin/_mocha -- build/test --reporter spec --slow 500",
63+
"test-only": "nyc mocha build/test --reporter spec --slow 500",
6464
"publish-gh-pages": "bash ./publish-gh-pages.sh",
6565
"lint": "gts check",
6666
"clean": "gts clean",
67-
"compile": "tsc -p . && cp src/operations_client_config.json build/src",
67+
"compile": "tsc -p . && cp src/*.json build/src && cp src/*.js build/src",
6868
"fix": "gts fix",
6969
"prepare": "npm run compile",
7070
"pretest-only": "npm run compile",
7171
"posttest": "npm run lint",
72-
"system-test": "nyc mocha --timeout 1200000 build/system-test/system.js",
72+
"system-test": "nyc mocha --timeout 1200000 build/system-test",
7373
"samples-test": "echo no sample tests 😱"
7474
},
7575
"repository": "googleapis/gax-nodejs",
Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

test/api_callable.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,6 @@ import * as sinon from 'sinon';
3333

3434
import * as gax from '../src/gax';
3535
import {GoogleError} from '../src/GoogleError';
36-
3736
import * as utils from './utils';
3837

3938
const fail = utils.fail;
@@ -45,8 +44,8 @@ const FAKE_STATUS_CODE_2 = (utils as any).FAKE_STATUS_CODE_1 + 1;
4544

4645
describe('createApiCall', () => {
4746
it('calls api call', (done) => {
48-
let deadlineArg;
49-
function func(argument, metadata, options, callback) {
47+
let deadlineArg: {};
48+
function func(argument: {}, metadata: {}, options, callback) {
5049
deadlineArg = options.deadline;
5150
callback(null, argument);
5251
}

tsconfig.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
"compilerOptions": {
44
"rootDir": ".",
55
"outDir": "build",
6-
"noImplicitAny": false,
7-
"noImplicitThis": false
6+
"noImplicitAny": false
87
},
98
"include": [
109
"src/*.ts",

0 commit comments

Comments
 (0)