Skip to content

Conversation

@suztomo
Copy link
Member

@suztomo suztomo commented May 1, 2025

This google-api-nodejs-client repository creates multiple Git tags upon one release pull request (commit). Example: #3650 (comment)

To adopt the new release pipeline based on Git tags, this tagPullRequestNumber creates an additional release-please-<pr number> tag to a release. We'll monitor that tag to trigger the release job. This doesn't change existing release tags.

Background: https://docs.google.com/document/d/1Y0Fv-sxLqYmjnXHry3WDq4XNPeQP1AEmsB83hNRCEY0/edit?usp=sharing&resourcekey=0-I2m8Z-mTD0-HY0TpkblOTQ

This design has been working good for google-cloud-go: https://github.com/googleapis/google-cloud-go/blob/main/.github/release-please.yml#L4

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

This google-api-nodejs-client repository creates multiple Git tags upon one release pull request (commit).

To adopt the new release pipeline based on Git tags, this `tagPullRequestNumber` creates an additional "release-please-<pr number>" tag to a release. We'll monitor that tag to trigger the release job.

Background: https://docs.google.com/document/d/1Y0Fv-sxLqYmjnXHry3WDq4XNPeQP1AEmsB83hNRCEY0/edit?usp=sharing&resourcekey=0-I2m8Z-mTD0-HY0TpkblOTQ
@suztomo suztomo requested a review from a team as a code owner May 1, 2025 17:29
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 1, 2025
@suztomo
Copy link
Member Author

suztomo commented May 1, 2025

@sofisl I remember we stopped "OwlBot Post Processor" for pull requests based on a forked-repository. Would you temporarily remove "OwlBot Post Processor" from the required checks?

@sofisl sofisl merged commit 6bb3c06 into googleapis:main May 1, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants