feat(core): add few more errors as retriable errors (#10026)

Author: bajajneha27

google-apis-core/lib/google/apis/core/http_command.rb

@@ -27,7 +27,10 @@ module Core
       class HttpCommand
         include Logging
 
-        RETRIABLE_ERRORS = [Google::Apis::ServerError, Google::Apis::RateLimitError, Google::Apis::TransmissionError]
+        RETRIABLE_ERRORS = [Google::Apis::ServerError,
+                            Google::Apis::RateLimitError,
+                            Google::Apis::TransmissionError,
+                            Google::Apis::RequestTimeOutError]
 
         begin
           require 'opencensus'
@@ -225,6 +228,9 @@ def check_status(status, header = nil, body = nil, message = nil)
           when 429
             message ||= 'Rate limit exceeded'
             raise Google::Apis::RateLimitError.new(message, status_code: status, header: header, body: body)
+          when 408
+            message ||= 'Request time out'
+            raise Google::Apis::RequestTimeOutError.new(message, status_code: status, header: header, body: body)
           when 304, 400, 402...500
             message ||= 'Invalid request'
             raise Google::Apis::ClientError.new(message, status_code: status, header: header, body: body)
@@ -278,7 +284,7 @@ def error(err, rethrow: false, &block)
             rescue Google::Apis::Error => e
               err = e
             end
-          elsif err.is_a?(HTTPClient::TimeoutError) || err.is_a?(SocketError)
+          elsif err.is_a?(HTTPClient::TimeoutError) || err.is_a?(SocketError) || err.is_a?(HTTPClient::KeepAliveDisconnected) || err.is_a?(Errno::ECONNREFUSED) || err.is_a?(Errno::ETIMEDOUT)
             err = Google::Apis::TransmissionError.new(err)
           end
           block.call(nil, err) if block_given?

google-apis-core/lib/google/apis/errors.rb

@@ -66,7 +66,11 @@ class RedirectError < Error
     class ClientError < Error
     end
 
-    # A 4xx class HTTP error occurred.
+    # A 408 HTTP error occurred.
+    class RequestTimeOutError < ClientError
+    end
+
+    # A 429 HTTP error occurred.
     class RateLimitError < Error
     end
 

google-apis-core/spec/google/apis/core/http_command_spec.rb

@@ -473,13 +473,41 @@ class DecryptResponse
     expect { command.execute(client) }.to raise_error(Google::Apis::TransmissionError)
   end
 
+  it 'should raise transmission error instead of connection reset' do
+    stub_request(:get, 'https://www.googleapis.com/zoo/animals').to_raise(HTTPClient::KeepAliveDisconnected)
+    command = Google::Apis::Core::HttpCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
+    command.options.retries = 0
+    expect { command.execute(client) }.to raise_error(Google::Apis::TransmissionError)
+  end
+
+  it 'should raise transmission error instead of connection timeout' do
+    stub_request(:get, 'https://www.googleapis.com/zoo/animals').to_raise(Errno::ETIMEDOUT)
+    command = Google::Apis::Core::HttpCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
+    command.options.retries = 0
+    expect { command.execute(client) }.to raise_error(Google::Apis::TransmissionError)
+  end
+
+  it 'should raise transmission error instead of connection refused' do
+    stub_request(:get, 'https://www.googleapis.com/zoo/animals').to_raise(Errno::ECONNREFUSED)
+    command = Google::Apis::Core::HttpCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
+    command.options.retries = 0
+    expect { command.execute(client) }.to raise_error(Google::Apis::TransmissionError)
+  end
+
   it 'should raise rate limit error for 429 status codes' do
     stub_request(:get, 'https://www.googleapis.com/zoo/animals').to_return(status: [429, ''])
     command = Google::Apis::Core::HttpCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
     command.options.retries = 0
     expect { command.execute(client) }.to raise_error(Google::Apis::RateLimitError)
   end
 
+  it 'should raise request timeout error for 408 status codes' do
+    stub_request(:get, 'https://www.googleapis.com/zoo/animals').to_return(status: [408, ''])
+    command = Google::Apis::Core::HttpCommand.new(:get, 'https://www.googleapis.com/zoo/animals')
+    command.options.retries = 0
+    expect { command.execute(client) }.to raise_error(Google::Apis::RequestTimeOutError)
+  end  
+
   it 'should not normalize unicode values by default' do
     stub_request(:get, 'https://www.googleapis.com/Cafe%CC%81').to_return(status: [200, ''])
     template = Addressable::Template.new('https://www.googleapis.com/{path}')