feat(core): Allow chunk size zero for storage resumable upload (#13283)

Author: bajajneha27

google-apis-core/lib/google/apis/core/storage_upload.rb

@@ -141,7 +141,7 @@ def send_upload_command(client)
           logger.debug { sprintf('Sending upload command to %s', @upload_url) }
 
           remaining_content_size = upload_io.size - @offset
-          current_chunk_size = remaining_content_size < @upload_chunk_size ? remaining_content_size : @upload_chunk_size
+          current_chunk_size = get_current_chunk_size remaining_content_size
 
           request_header = header.dup
           request_header[CONTENT_RANGE_HEADER] = get_content_range_header current_chunk_size
@@ -181,6 +181,15 @@ def streamable?(upload_source)
           upload_source.is_a?(IO) || upload_source.is_a?(StringIO) || upload_source.is_a?(Tempfile)
         end
 
+        def get_current_chunk_size remaining_content_size
+          # Disable chunking if the chunk size is set to zero.
+          if @upload_chunk_size == 0
+            remaining_content_size
+          else
+            remaining_content_size < @upload_chunk_size ? remaining_content_size : @upload_chunk_size
+          end
+        end
+
         def get_content_range_header current_chunk_size
           if upload_io.size == 0
             numerator = "*"

google-apis-core/spec/google/apis/core/storage_upload_spec.rb

@@ -129,6 +129,18 @@
     end
   end
 
+  context('with chunking disabled') do
+    let(:file) { StringIO.new("Hello world")}
+    include_examples 'should upload'
+
+    it 'should upload content in one request' do
+      command.options.upload_chunk_size = 0
+      command.execute(client)
+      expect(a_request(:put, 'https://www.googleapis.com/zoo/animals')
+        .with(body: "Hello world")).to have_been_made
+    end
+  end
+
   context 'with retriable error on start' do
     let(:file) { StringIO.new "Hello world"}
     before(:example) do