getConfig + javadocs.

Author: rmehta19

oauth2_http/java/com/google/auth/oauth2/SecureSessionAgent.java

@@ -72,18 +72,20 @@ public class SecureSessionAgent {
   private static final String MDS_MTLS_ENDPOINT =
       ComputeEngineCredentials.getMetadataServerUrl() + S2A_CONFIG_ENDPOINT_POSTFIX;
 
-  private SecureSessionAgentConfig config;
-
   private transient HttpTransportFactory transportFactory;
 
   SecureSessionAgent(SecureSessionAgent.Builder builder) {
     this.transportFactory = builder.getHttpTransportFactory();
-    this.config = getSecureSessionAgentConfigFromMDS();
   }
 
-  /** @return the cached SecureSessionAgentConfig. */
-  public SecureSessionAgentConfig getConfigFromMDS() {
-    return config;
+  /**
+   * This method makes a network call to MDS to get the {@link SecureSessionAgentConfig} which
+   * contains the plaintext and mtls address to reach the S2A (Secure Session Agent).
+   *
+   * @return the cached SecureSessionAgentConfig.
+   */
+  public SecureSessionAgentConfig getConfig() {
+    return getSecureSessionAgentConfigFromMDS();
   }
 
   public static Builder newBuilder() {

oauth2_http/javatests/com/google/auth/oauth2/MockMetadataServerTransport.java

@@ -337,6 +337,7 @@ protected boolean isIdentityDocumentUrl(String url) {
   protected boolean isMtlsConfigRequestUrl(String url) {
     return url.equals(
         String.format(
-            ComputeEngineCredentials.getMetadataServerUrl() + SecureSessionAgent.S2A_CONFIG_ENDPOINT_POSTFIX));
+            ComputeEngineCredentials.getMetadataServerUrl()
+                + SecureSessionAgent.S2A_CONFIG_ENDPOINT_POSTFIX));
   }
 }

oauth2_http/javatests/com/google/auth/oauth2/SecureSessionAgentTest.java

@@ -61,7 +61,7 @@ public void getS2AAddress_validAddress() {
 
     SecureSessionAgent s2aUtils =
         SecureSessionAgent.newBuilder().setHttpTransportFactory(transportFactory).build();
-    SecureSessionAgentConfig config = s2aUtils.getConfigFromMDS();
+    SecureSessionAgentConfig config = s2aUtils.getConfig();
     String plaintextS2AAddress = config.getPlaintextAddress();
     String mtlsS2AAddress = config.getMtlsAddress();
     assertEquals(S2A_PLAINTEXT_ADDRESS, plaintextS2AAddress);
@@ -82,7 +82,7 @@ public void getS2AAddress_queryEndpointResponseErrorCode_emptyAddress() {
 
     SecureSessionAgent s2aUtils =
         SecureSessionAgent.newBuilder().setHttpTransportFactory(transportFactory).build();
-    SecureSessionAgentConfig config = s2aUtils.getConfigFromMDS();
+    SecureSessionAgentConfig config = s2aUtils.getConfig();
     String plaintextS2AAddress = config.getPlaintextAddress();
     String mtlsS2AAddress = config.getMtlsAddress();
     assertTrue(plaintextS2AAddress.isEmpty());
@@ -103,7 +103,7 @@ public void getS2AAddress_queryEndpointResponseEmpty_emptyAddress() {
 
     SecureSessionAgent s2aUtils =
         SecureSessionAgent.newBuilder().setHttpTransportFactory(transportFactory).build();
-    SecureSessionAgentConfig config = s2aUtils.getConfigFromMDS();
+    SecureSessionAgentConfig config = s2aUtils.getConfig();
     String plaintextS2AAddress = config.getPlaintextAddress();
     String mtlsS2AAddress = config.getMtlsAddress();
     assertTrue(plaintextS2AAddress.isEmpty());
@@ -123,7 +123,7 @@ public void getS2AAddress_queryEndpointResponseInvalidPlaintextJsonKey_plaintext
 
     SecureSessionAgent s2aUtils =
         SecureSessionAgent.newBuilder().setHttpTransportFactory(transportFactory).build();
-    SecureSessionAgentConfig config = s2aUtils.getConfigFromMDS();
+    SecureSessionAgentConfig config = s2aUtils.getConfig();
     String plaintextS2AAddress = config.getPlaintextAddress();
     String mtlsS2AAddress = config.getMtlsAddress();
     assertTrue(plaintextS2AAddress.isEmpty());
@@ -143,7 +143,7 @@ public void getS2AAddress_queryEndpointResponseInvalidMtlsJsonKey_mtlsEmptyAddre
 
     SecureSessionAgent s2aUtils =
         SecureSessionAgent.newBuilder().setHttpTransportFactory(transportFactory).build();
-    SecureSessionAgentConfig config = s2aUtils.getConfigFromMDS();
+    SecureSessionAgentConfig config = s2aUtils.getConfig();
     String plaintextS2AAddress = config.getPlaintextAddress();
     String mtlsS2AAddress = config.getMtlsAddress();
     assertEquals(S2A_PLAINTEXT_ADDRESS, plaintextS2AAddress);