Skip to content

Commit 7c95364

Browse files
committed
pom slf4j2x-test profile cleanup.
1 parent 5bcd4ee commit 7c95364

File tree

2 files changed

+6
-22
lines changed

2 files changed

+6
-22
lines changed

oauth2_http/pom.xml

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -135,27 +135,7 @@
135135
use instead of the default slf4j2x.
136136
This should merge with the profile with the same name
137137
in the parent module -->
138-
<build>
139-
<plugins>
140-
<plugin>
141-
<artifactId>maven-compiler-plugin</artifactId>
142-
<version>3.13.0</version>
143-
<configuration>
144-
<source>1.8</source>
145-
<target>1.8</target>
146-
<encoding>UTF-8</encoding>
147-
<!-- excluding tests depending on logback/env var by default -->
148-
<testIncludes>
149-
<testInclude>**/Slf4jUtilsLogbackTest.java</testInclude>
150-
<testInclude>**/Slf4jUtils1xTest.java</testInclude>
151-
<testInclude>**/Slf4jUtilsTest.java</testInclude>
152-
<testInclude>**/TestAppender.java</testInclude>
153-
<testInclude>**/LoggingTest.java</testInclude>
154-
</testIncludes>
155-
</configuration>
156-
</plugin>
157-
</plugins>
158-
</build>
138+
<!-- Run test with `mvn clean test -P '!slf4j2x,slf4j2x-test'` -->
159139
<dependencies>
160140
<dependency>
161141
<groupId>org.slf4j</groupId>

pom.xml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -423,7 +423,11 @@
423423
<profiles>
424424
<profile>
425425
<id>slf4j2x-test</id>
426-
<!-- This profile is for logging test only, use instead of the default slf4j2x -->
426+
<!-- This profile is for logging test only, use instead of the default slf4j2x -->
427+
<!-- testInclude for compiler is in this parent pom because it affects
428+
test classes from other modules -->
429+
<!-- To run logging tests, use this in addition to `slf4j2x-test`profile
430+
in oauth2_http module -->
427431
<build>
428432
<plugins>
429433
<plugin>

0 commit comments

Comments
 (0)