Skip to content

Commit 8af2d9c

Browse files
committed
Removed unnecessary refreshTrustBoundaryAndGetAdditionalHeaders as tb refresh now happens within access token refresh of individual classes.
1 parent dfc7ec3 commit 8af2d9c

File tree

2 files changed

+3
-28
lines changed

2 files changed

+3
-28
lines changed

oauth2_http/java/com/google/auth/oauth2/GoogleCredentials.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -346,19 +346,11 @@ protected void refreshTrustBoundaries(AccessToken newAccessToken) throws IOExcep
346346

347347
@Override
348348
protected Map<String, List<String>> getAdditionalHeaders() {
349-
Map<String, List<String>> headers = super.getAdditionalHeaders();
349+
Map<String, List<String>> headers = new HashMap<>(super.getAdditionalHeaders());
350350
String quotaProjectId = this.getQuotaProjectId();
351351
if (quotaProjectId != null) {
352-
return addQuotaProjectIdToRequestMetadata(quotaProjectId, headers);
352+
headers.put(QUOTA_PROJECT_ID_HEADER_KEY, Collections.singletonList(quotaProjectId));
353353
}
354-
return headers;
355-
}
356-
357-
@Override
358-
protected Map<String, List<String>> refreshTrustBoundaryAndGetAdditionalHeaders(AccessToken newAccessToken) throws IOException{
359-
Map<String, List<String>> headers = new HashMap<>(getAdditionalHeaders());
360-
361-
refreshTrustBoundaries(newAccessToken);
362354

363355
if (this.trustBoundary != null) {
364356
String headerValue = trustBoundary.isNoOp() ? "" : trustBoundary.getEncodedLocations();

oauth2_http/java/com/google/auth/oauth2/OAuth2Credentials.java

Lines changed: 1 addition & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -266,14 +266,7 @@ private AsyncRefreshResult getOrCreateRefreshTask() {
266266
final ListenableFutureTask<OAuthValue> task =
267267
ListenableFutureTask.create(
268268
() -> {
269-
AccessToken newAccessToken = refreshAccessToken();
270-
Map<String, List<String>> newHeaders;
271-
if(this instanceof TrustBoundaryProvider) {
272-
newHeaders = refreshTrustBoundaryAndGetAdditionalHeaders(newAccessToken);
273-
} else{
274-
newHeaders = getAdditionalHeaders();
275-
}
276-
return OAuthValue.create(newAccessToken, newHeaders);
269+
return OAuthValue.create(refreshAccessToken(), getAdditionalHeaders());
277270
});
278271

279272
refreshTask = new RefreshTask(task, new RefreshTaskListener(task));
@@ -384,16 +377,6 @@ protected Map<String, List<String>> getAdditionalHeaders() {
384377
return EMPTY_EXTRA_HEADERS;
385378
}
386379

387-
/**
388-
* Refresh trust boundary and get additional headers to return as request metadata.
389-
*
390-
* @return additional headers.
391-
*/
392-
protected Map<String, List<String>> refreshTrustBoundaryAndGetAdditionalHeaders(AccessToken newAccessToken) throws IOException {
393-
return EMPTY_EXTRA_HEADERS;
394-
}
395-
396-
397380
/**
398381
* Adds a listener that is notified when the Credentials data changes.
399382
*

0 commit comments

Comments
 (0)