Skip to content

Commit 9d46bbd

Browse files
committed
null or empty.
1 parent 47ec152 commit 9d46bbd

File tree

2 files changed

+51
-2
lines changed

2 files changed

+51
-2
lines changed

oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@
5050
import com.google.common.annotations.VisibleForTesting;
5151
import com.google.common.base.Joiner;
5252
import com.google.common.base.MoreObjects.ToStringHelper;
53+
import com.google.common.base.Strings;
5354
import com.google.common.collect.ImmutableList;
5455
import com.google.common.collect.ImmutableSet;
5556
import com.google.errorprone.annotations.CanIgnoreReturnValue;
@@ -208,10 +209,10 @@ String createTokenUrlWithScopes() {
208209
if (!scopes.isEmpty()) {
209210
tokenUrl.set("scopes", Joiner.on(',').join(scopes));
210211
}
211-
if (!transport.isEmpty()) {
212+
if (!Strings.isNullOrEmpty(transport)) {
212213
tokenUrl.set("transport", transport);
213214
}
214-
if (!bindingEnforcement.isEmpty()) {
215+
if (!Strings.isNullOrEmpty(bindingEnforcement)) {
215216
tokenUrl.set("binding-enforcement", bindingEnforcement);
216217
}
217218
return tokenUrl.toString();

oauth2_http/javatests/com/google/auth/oauth2/ComputeEngineCredentialsTest.java

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -190,6 +190,54 @@ public void buildTokenUrlWithScopes_defaultScopes() {
190190
assertEquals("bar", scopes.toArray()[1]);
191191
}
192192

193+
@Test
194+
public void buildTokenUrl_emptyTransport() {
195+
ComputeEngineCredentials credentials =
196+
ComputeEngineCredentials.newBuilder()
197+
.setTransport("")
198+
.setBindingEnforcement("abc")
199+
.build();
200+
String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
201+
202+
assertEquals(TOKEN_URL + "?binding-enforcement=abc", softBoundTokenUrl);
203+
}
204+
205+
@Test
206+
public void buildTokenUrl_nullTransport() {
207+
ComputeEngineCredentials credentials =
208+
ComputeEngineCredentials.newBuilder()
209+
.setTransport(null)
210+
.setBindingEnforcement("abc")
211+
.build();
212+
String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
213+
214+
assertEquals(TOKEN_URL + "?binding-enforcement=abc", softBoundTokenUrl);
215+
}
216+
217+
@Test
218+
public void buildTokenUrl_emptyBindingEnforcement() {
219+
ComputeEngineCredentials credentials =
220+
ComputeEngineCredentials.newBuilder()
221+
.setTransport("abc")
222+
.setBindingEnforcement("")
223+
.build();
224+
String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
225+
226+
assertEquals(TOKEN_URL + "?transport=abc", softBoundTokenUrl);
227+
}
228+
229+
@Test
230+
public void buildTokenUrl_nullBindingEnforcement() {
231+
ComputeEngineCredentials credentials =
232+
ComputeEngineCredentials.newBuilder()
233+
.setTransport("abc")
234+
.setBindingEnforcement(null)
235+
.build();
236+
String softBoundTokenUrl = credentials.createTokenUrlWithScopes();
237+
238+
assertEquals(TOKEN_URL + "?transport=abc", softBoundTokenUrl);
239+
}
240+
193241
@Test
194242
public void buildTokenUrlSoftMtlsBound_mtls_transport() {
195243
ComputeEngineCredentials credentials =

0 commit comments

Comments
 (0)