Skip to content

Commit e1d9a78

Browse files
committed
comments.:
1 parent 3b8205d commit e1d9a78

File tree

2 files changed

+7
-0
lines changed

2 files changed

+7
-0
lines changed

oauth2_http/java/com/google/auth/oauth2/Slf4jLoggingHelpers.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -109,6 +109,7 @@ static void logRequest(HttpRequest request, LoggerProvider loggerProvider, Strin
109109
}
110110
}
111111

112+
/** Logs response status code, status.message, and headers */
112113
static void logResponse(HttpResponse response, LoggerProvider loggerProvider, String message) {
113114
try {
114115
Logger logger = loggerProvider.getLogger();
@@ -126,6 +127,7 @@ static void logResponse(HttpResponse response, LoggerProvider loggerProvider, St
126127
}
127128
}
128129

130+
/** Logs parsed response payload */
129131
static void logResponsePayload(
130132
GenericData genericData, LoggerProvider loggerProvider, String message) {
131133
try {
@@ -155,6 +157,7 @@ private static Map<String, Object> parseGenericData(GenericData genericData) {
155157
return contextMap;
156158
}
157159

160+
// calculate SHA256Hash so we do not print secrets directly to log
158161
private static String calculateSHA256Hash(String data) {
159162
try {
160163
MessageDigest digest = MessageDigest.getInstance("SHA-256");

oauth2_http/java/com/google/auth/oauth2/Slf4jUtils.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,10 @@ class Slf4jUtils {
4848
private static boolean isSLF4J2x;
4949

5050
static {
51+
// this class was added as part of the Fluent API introduced since v2.0.0
52+
// (https://www.slf4j.org/manual.html#fluent), not available in v1.7.36
53+
// see
54+
// https://github.com/qos-ch/slf4j/commits/v_2.0.0/slf4j-api/src/main/java/org/slf4j/event/KeyValuePair.java
5155
isSLF4J2x = checkIfClazzAvailable("org.slf4j.event.KeyValuePair");
5256
}
5357

0 commit comments

Comments
 (0)