rename method logResponsePayload

Author: zhumin8

oauth2_http/java/com/google/auth/oauth2/ComputeEngineCredentials.java

@@ -373,7 +373,7 @@ public AccessToken refreshAccessToken() throws IOException {
       throw new IOException(METADATA_RESPONSE_EMPTY_CONTENT_ERROR_MESSAGE);
     }
     GenericData responseData = response.parseAs(GenericData.class);
-    LoggingUtils.logGenericData(responseData, LOGGER_PROVIDER, "Response payload for access token");
+    LoggingUtils.logResponsePayload(responseData, LOGGER_PROVIDER, "Response payload for access token");
     String accessToken =
         OAuth2Utils.validateString(responseData, "access_token", PARSE_ERROR_PREFIX);
     int expiresInSeconds =
@@ -755,7 +755,7 @@ private String getDefaultServiceAccount() throws IOException {
       throw new IOException(METADATA_RESPONSE_EMPTY_CONTENT_ERROR_MESSAGE);
     }
     GenericData responseData = response.parseAs(GenericData.class);
-    LoggingUtils.logGenericData(
+    LoggingUtils.logResponsePayload(
         responseData, LOGGER_PROVIDER, "Received default service account payload");
     Map<String, Object> defaultAccount =
         OAuth2Utils.validateMap(responseData, "default", PARSE_ERROR_ACCOUNT);

oauth2_http/java/com/google/auth/oauth2/IamUtils.java

@@ -186,7 +186,7 @@ private static String getSignature(
     }
 
     GenericData responseData = response.parseAs(GenericData.class);
-    LoggingUtils.logGenericData(responseData, LOGGER_PROVIDER, "Response payload for sign blob");
+    LoggingUtils.logResponsePayload(responseData, LOGGER_PROVIDER, "Response payload for sign blob");
     return OAuth2Utils.validateString(responseData, "signedBlob", PARSE_ERROR_SIGNATURE);
   }
 
@@ -268,7 +268,7 @@ static IdToken getIdToken(
     }
 
     GenericJson responseData = response.parseAs(GenericJson.class);
-    LoggingUtils.logGenericData(
+    LoggingUtils.logResponsePayload(
         responseData, LOGGER_PROVIDER, "Response payload for ID token request");
     String rawToken = OAuth2Utils.validateString(responseData, "token", PARSE_ERROR_MESSAGE);
     return IdToken.create(rawToken);

oauth2_http/java/com/google/auth/oauth2/ImpersonatedCredentials.java

@@ -564,7 +564,7 @@ public AccessToken refreshAccessToken() throws IOException {
     }
 
     GenericData responseData = response.parseAs(GenericData.class);
-    LoggingUtils.logGenericData(responseData, LOGGER_PROVIDER, "Response payload for access token");
+    LoggingUtils.logResponsePayload(responseData, LOGGER_PROVIDER, "Response payload for access token");
     response.disconnect();
 
     String accessToken =

oauth2_http/java/com/google/auth/oauth2/LoggingUtils.java

@@ -66,10 +66,10 @@ static void logResponse(HttpResponse response, LoggerProvider loggerProvider, St
     }
   }
 
-  static void logGenericData(
+  static void logResponsePayload(
       GenericData genericData, LoggerProvider loggerProvider, String message) {
     if (loggingEnabled) {
-      Slf4jUtils.logGenericData(genericData, loggerProvider, message);
+      Slf4jUtils.logResponsePayload(genericData, loggerProvider, message);
     }
   }
 }

oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java

@@ -507,7 +507,7 @@ boolean isConfiguredForDomainWideDelegation() {
 
   private GenericData parseResponseAs(HttpResponse response) throws IOException {
     GenericData genericData = response.parseAs(GenericData.class);
-    LoggingUtils.logGenericData(genericData, LOGGER_PROVIDER, "Response payload");
+    LoggingUtils.logResponsePayload(genericData, LOGGER_PROVIDER, "Response payload");
     return genericData;
   }
   /**

oauth2_http/java/com/google/auth/oauth2/Slf4jUtils.java

@@ -214,7 +214,7 @@ static void logRequest(HttpRequest request, LoggerProvider loggerProvider, Strin
         }
       }
     } catch (Exception e) {
-
+      // let logging fail silently
     }
   }
 
@@ -231,12 +231,11 @@ static void logResponse(HttpResponse response, LoggerProvider loggerProvider, St
         log(logger, org.slf4j.event.Level.INFO, responseLogDataMap, message);
       }
     } catch (Exception e) {
-
-      // logger.error("Error logging response: ", e);
+      // let logging fail silently
     }
   }
 
-  static void logGenericData(
+  static void logResponsePayload(
       GenericData genericData, LoggerProvider loggerProvider, String message) {
     try {
 
@@ -246,7 +245,7 @@ static void logGenericData(
         log(logger, org.slf4j.event.Level.DEBUG, contextMap, message);
       }
     } catch (Exception e) {
-      // logger.error("Error logging GenericData: ", e);
+      // let logging fail silently
     }
   }
 

oauth2_http/java/com/google/auth/oauth2/UserCredentials.java

@@ -297,7 +297,7 @@ private GenericData doRefreshAccessToken() throws IOException {
 
     GenericData data = response.parseAs(GenericData.class);
 
-    LoggingUtils.logGenericData(data, LOGGER_PROVIDER, "Response payload for access token");
+    LoggingUtils.logResponsePayload(data, LOGGER_PROVIDER, "Response payload for access token");
     return data;
   }
 

oauth2_http/javatests/com/google/auth/oauth2/Slf4jUtils1xTest.java

@@ -67,7 +67,7 @@ public void testLogGenericData() {
 
     LoggerProvider loggerProvider = Mockito.mock(LoggerProvider.class);
     when(loggerProvider.getLogger()).thenReturn(LOGGER);
-    LoggingUtils.logGenericData(data, loggerProvider, "test generic data");
+    LoggingUtils.logResponsePayload(data, loggerProvider, "test generic data");
 
     assertEquals(1, testAppender.events.size());
     Map<String, String> mdcPropertyMap = testAppender.events.get(0).getMDCPropertyMap();

oauth2_http/javatests/com/google/auth/oauth2/Slf4jUtilsLogbackTest.java

@@ -144,7 +144,7 @@ public void testLogGenericData() {
 
     LoggerProvider loggerProvider = mock(LoggerProvider.class);
     when(loggerProvider.getLogger()).thenReturn(LOGGER);
-    LoggingUtils.logGenericData(data, loggerProvider, "test generic data");
+    LoggingUtils.logResponsePayload(data, loggerProvider, "test generic data");
 
     assertEquals(1, testAppender.events.size());
     List<KeyValuePair> keyValuePairs = testAppender.events.get(0).getKeyValuePairs();