Skip to content

1296: Added reactive binding #1297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

1296: Added reactive binding #1297

wants to merge 2 commits into from

Conversation

@gkatzioura
Copy link

@gkatzioura gkatzioura commented Oct 5, 2023

Thi PR provides the functionality to generate api tokens in a reactive way.

  • [* ] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1296 ☕️

If you write sample code, please follow the samples format.

@gkatzioura gkatzioura requested review from a team as code owners October 5, 2023 07:22
@product-auto-label product-auto-label bot added the size: xl Pull request size is extra large. label Oct 5, 2023
@gkatzioura gkatzioura mentioned this pull request Oct 5, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@meltsufin
Copy link
Member

meltsufin commented Oct 5, 2023

@TimurSadykov Would you be able to give some initial feedback on this proposal?

@gkatzioura gkatzioura mentioned this pull request Oct 6, 2023
Open
@TimurSadykov
Copy link

TimurSadykov commented Feb 6, 2024

Sorry for a delay, this is pending internal discussion, will update sometime this month

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add reactor Bindings

3 participants

@gkatzioura @meltsufin @TimurSadykov