fix: fix vm universe_domain bug (#1433)

Author: arithmetic1728

google/auth/compute_engine/credentials.py

@@ -28,6 +28,7 @@
 from google.auth import jwt
 from google.auth import metrics
 from google.auth.compute_engine import _metadata
+from google.auth.transport import requests as google_auth_requests
 from google.oauth2 import _client
 
 
@@ -74,6 +75,7 @@ def __init__(
         self._scopes = scopes
         self._default_scopes = default_scopes
         self._universe_domain_cached = False
+        self._universe_domain_request = google_auth_requests.Request()
 
     def _retrieve_info(self, request):
         """Retrieve information about the service account.
@@ -136,7 +138,9 @@ def requires_scopes(self):
     def universe_domain(self):
         if self._universe_domain_cached:
             return self._universe_domain
-        self._universe_domain = _metadata.get_universe_domain()
+        self._universe_domain = _metadata.get_universe_domain(
+            self._universe_domain_request
+        )
         self._universe_domain_cached = True
         return self._universe_domain
 

system_tests/secrets.tar.enc

@@ -221,12 +221,16 @@ def test_universe_domain(self, get_universe_domain):
         assert self.credentials.universe_domain == "fake_universe_domain"
         assert self.credentials._universe_domain == "fake_universe_domain"
         assert self.credentials._universe_domain_cached
-        get_universe_domain.assert_called_once()
+        get_universe_domain.assert_called_once_with(
+            self.credentials._universe_domain_request
+        )
 
         # calling the universe_domain property the second time should use the
         # cached value instead of calling get_universe_domain
         assert self.credentials.universe_domain == "fake_universe_domain"
-        get_universe_domain.assert_called_once()
+        get_universe_domain.assert_called_once_with(
+            self.credentials._universe_domain_request
+        )
 
 
 class TestIDTokenCredentials(object):