Skip to content

Commit a2e2cd7

Browse files
committed
also disable 3.7/3.8 samples tests
1 parent 52da173 commit a2e2cd7

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

noxfile.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@
3434
]
3535

3636
DEFAULT_PYTHON_VERSION = "3.10"
37+
# TODO(https://github.com/googleapis/google-auth-library-python-oauthlib/issues/410):
38+
# Remove or restore testing for Python 3.7/3.8
39+
UNIT_TEST_PYTHON_VERSIONS = ["3.9", "3.10", "3.11", "3.12", "3.13"]
40+
3741
# Error if a python version is missing
3842
nox.options.error_on_missing_interpreters = True
3943

@@ -88,9 +92,7 @@ def mypy(session):
8892
session.run("mypy", "-p", "google", "-p", "tests", "-p", "tests_async")
8993

9094

91-
# TODO(https://github.com/googleapis/google-auth-library-python-oauthlib/issues/410):
92-
# Remove or restore testing for Python 3.7/3.8
93-
@nox.session(python=["3.9", "3.10", "3.11", "3.12", "3.13"])
95+
@nox.session(python=UNIT_TEST_PYTHON_VERSIONS)
9496
def unit(session):
9597
constraints_path = str(
9698
CURRENT_DIRECTORY / "testing" / f"constraints-{session.python}.txt"

samples/cloud-client/snippets/noxfile_config.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,9 @@
2222

2323
TEST_CONFIG_OVERRIDE = {
2424
# You can opt out from the test for specific Python versions.
25-
"ignored_versions": ["2.7"],
25+
# TODO(https://github.com/googleapis/google-auth-library-python-oauthlib/issues/410):
26+
# Remove or restore testing for Python 3.7/3.8
27+
"ignored_versions": ["2.7", "3.7", "3.8"],
2628
# Old samples are opted out of enforcing Python type hints
2729
# All new samples should feature them
2830
"enforce_type_hints": True,

0 commit comments

Comments
 (0)