simplify interface

Author: sai-sunder-s

google/auth/_default.py

@@ -77,6 +77,7 @@ def _warn_about_problematic_credentials(credentials):
         warnings.warn(_CLOUD_SDK_CREDENTIALS_WARNING)
 
 
+# deprecate
 def load_credentials_from_file(
     filename, scopes=None, default_scopes=None, quota_project_id=None, request=None
 ):
@@ -125,16 +126,37 @@ def load_credentials_from_file(
             )
             raise new_exc from caught_exc
     return _load_credentials_from_info(
-        filename, info, scopes, default_scopes, quota_project_id, request
+        filename,
+        info,
+        scopes,
+        default_scopes,
+        quota_project_id,
+        request,
+        constraints.Constraints.allow_everything_insecure(),
     )
 
+
+# deprecate
 def load_credentials_from_dict(
     info, scopes=None, default_scopes=None, quota_project_id=None, request=None
 ):
-    return load_credentials_from_dict_with_constraints(info, constraints.Constraints(allow_types="all"), scopes, default_scopes, quota_project_id, request)
+    return load_credentials_from_dict_constrained(
+        info,
+        constraints.Constraints.allow_everything_insecure(),
+        scopes,
+        default_scopes,
+        quota_project_id,
+        request,
+    )
 
-def load_credentials_from_dict_with_constraints(
-    info, constraints, scopes=None, default_scopes=None, quota_project_id=None, request=None
+
+def load_credentials_from_dict_constrained(
+    info,
+    constraints,
+    scopes=None,
+    default_scopes=None,
+    quota_project_id=None,
+    request=None,
 ):
     """Loads Google credentials from a dict.
 
@@ -173,7 +195,13 @@ def load_credentials_from_dict_with_constraints(
         )
 
     return _load_credentials_from_info(
-        "dict object", info, scopes, default_scopes, quota_project_id, request
+        "dict object",
+        info,
+        scopes,
+        default_scopes,
+        quota_project_id,
+        request,
+        constraints,
     )
 
 
@@ -184,8 +212,10 @@ def _load_credentials_from_info(
 
     credential_type = info.get("type")
 
-    if constraints.isValid(info) is False:
-        raise exceptions.InvalidType(f"{credential_type} is not allowed as per provided constraints or is not a valid credential type") 
+    if constraints.is_valid(info) is False:
+        raise exceptions.InvalidType(
+            f"The provided {credential_type} is not allowed as per provided constraints or is not a valid credential type"
+        )
 
     if credential_type == _AUTHORIZED_USER_TYPE:
         credentials, project_id = _get_authorized_user_credentials(