chore: remove logging for async requests (#1698)

* chore: remove logging for async requests

* change Dict to Mapping

* fix mypy and lint issues

* address PR feedback

* link issue

Author: ohmayr

google/auth/_helpers.py

@@ -21,13 +21,15 @@
 import hashlib
 import logging
 import sys
-from typing import Optional, Dict, Any
+from typing import Any, Mapping, Optional
 import urllib
 
 from google.auth import exceptions
 
 try:
-    from google.api_core import client_logging
+    # TODO(https://github.com/googleapis/python-api-core/issues/813): Remove `# type: ignore` when
+    # `google-api-core` type hints issue is resolved.
+    from google.api_core import client_logging  # type: ignore # noqa: F401
 
     CLIENT_LOGGING_SUPPORTED = True  # pragma: NO COVER
 # TODO(https://github.com/googleapis/google-auth-library-python/issues/1690): Remove `pragma: NO COVER` once
@@ -314,7 +316,7 @@ def hash_sensitive_info(data: dict) -> dict:
     return hashed_data
 
 
-def _hash_value(value, field_name: str) -> str:
+def _hash_value(value, field_name: str) -> Optional[str]:
     """Hashes a value and returns a formatted hash string."""
     if value is None:
         return None
@@ -343,7 +345,7 @@ def request_log(
     method: str,
     url: str,
     body: Optional[Any],
-    headers: Optional[Dict[str, str]],
+    headers: Optional[Mapping[str, str]],
 ) -> None:
     """
     Logs an HTTP request at the DEBUG level if logging is enabled.

google/auth/aio/transport/aiohttp.py

@@ -167,7 +167,7 @@ async def __call__(
                 timeout=client_timeout,
                 **kwargs,
             )
-            _helpers.response_log(_LOGGER, response)
+            # TODO(https://github.com/googleapis/google-auth-library-python/issues/1697): Add response log.
             return Response(response)
 
         except aiohttp.ClientError as caught_exc:

google/auth/transport/_aiohttp_requests.py

@@ -22,14 +22,14 @@
 
 import asyncio
 import functools
+import logging
 
 import aiohttp  # type: ignore
-import logging
 import urllib3  # type: ignore
 
+from google.auth import _helpers
 from google.auth import exceptions
 from google.auth import transport
-from google.auth import _helpers
 from google.auth.transport import requests
 
 
@@ -191,7 +191,7 @@ async def __call__(
             response = await self.session.request(
                 method, url, data=body, headers=headers, timeout=timeout, **kwargs
             )
-            _helpers.response_log(_LOGGER, response)
+            # TODO(https://github.com/googleapis/google-auth-library-python/issues/1697): Add response log.
             return _CombinedResponse(response)
 
         except aiohttp.ClientError as caught_exc:

google/auth/transport/_http_client.py

@@ -19,9 +19,9 @@
 import socket
 import urllib
 
+from google.auth import _helpers
 from google.auth import exceptions
 from google.auth import transport
-from google.auth import _helpers
 
 _LOGGER = logging.getLogger(__name__)
 

google/auth/transport/requests.py

@@ -34,10 +34,10 @@
     create_urllib3_context,
 )  # pylint: disable=ungrouped-imports
 
+from google.auth import _helpers
 from google.auth import environment_vars
 from google.auth import exceptions
 from google.auth import transport
-from google.auth import _helpers
 import google.auth.transport._mtls_helper
 from google.oauth2 import service_account
 

google/auth/transport/urllib3.py

@@ -42,10 +42,10 @@
 
 from packaging import version  # type: ignore
 
+from google.auth import _helpers
 from google.auth import environment_vars
 from google.auth import exceptions
 from google.auth import transport
-from google.auth import _helpers
 from google.oauth2 import service_account
 
 if version.parse(urllib3.__version__) >= version.parse("2.0.0"):  # pragma: NO COVER

tests/test__helpers.py

@@ -13,9 +13,9 @@
 # limitations under the License.
 
 import datetime
-import urllib
 import logging
 from unittest import mock
+import urllib
 
 import pytest  # type: ignore