Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Commit d96ba55

Browse files
authored
cleanup: use more idiomatic name for function (#167)
1 parent 946b6d3 commit d96ba55

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

google/cloud/internal/future_impl.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,7 @@ class future_shared_state_base {
204204
continuation_ = std::move(c);
205205
}
206206

207-
std::function<void()> extract_cancellation_callback() {
207+
std::function<void()> release_cancellation_callback() {
208208
return std::move(cancellation_callback_);
209209
}
210210

@@ -349,8 +349,8 @@ class future_shared_state final : private future_shared_state_base {
349349

350350
using future_shared_state_base::abandon;
351351
using future_shared_state_base::cancel;
352-
using future_shared_state_base::extract_cancellation_callback;
353352
using future_shared_state_base::is_ready;
353+
using future_shared_state_base::release_cancellation_callback;
354354
using future_shared_state_base::set_continuation;
355355
using future_shared_state_base::set_exception;
356356
using future_shared_state_base::wait;
@@ -478,8 +478,8 @@ class future_shared_state<void> final : private future_shared_state_base {
478478

479479
using future_shared_state_base::abandon;
480480
using future_shared_state_base::cancel;
481-
using future_shared_state_base::extract_cancellation_callback;
482481
using future_shared_state_base::is_ready;
482+
using future_shared_state_base::release_cancellation_callback;
483483
using future_shared_state_base::set_continuation;
484484
using future_shared_state_base::set_exception;
485485
using future_shared_state_base::wait;
@@ -673,7 +673,7 @@ struct continuation : public continuation_base {
673673
: functor(std::move(f)),
674674
input(std::move(s)),
675675
output(std::make_shared<future_shared_state<result_t>>(
676-
input.lock()->extract_cancellation_callback())) {}
676+
input.lock()->release_cancellation_callback())) {}
677677

678678
continuation(Functor&& f, std::shared_ptr<input_shared_state_t> s,
679679
std::shared_ptr<output_shared_state_t> o)
@@ -729,7 +729,7 @@ struct unwrapping_continuation : public continuation_base {
729729
input(std::move(s)),
730730
intermediate(),
731731
output(std::make_shared<output_shared_state_t>(
732-
input.lock()->extract_cancellation_callback())) {}
732+
input.lock()->release_cancellation_callback())) {}
733733

734734
void execute() override {
735735
auto tmp = input.lock();

0 commit comments

Comments
 (0)