Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Commit 12fed2e

Browse files
authored
feat: adds BUILD target to top-level BUILD file (#1396)
* feat: adds BUILD target to top-level BUILD file Adds user-facing bazel build targets to the project's top-level BUILD file. This file should list *all* of the BUILD targets that users are allowed to use. In a future PR, visibility restrictions should prohibit users from reaching down into `google/cloud/spanner/BUILD`. This change will make things simpler for users since they'll have a single, uncomplicated, top-level BUILD file that contains all the build targets that they're allowed to use. It also gives us a place to put an `includes = ["."]` directive, which will allow Bazel users to include our headers using either double quotes or angle brackets. Related to #1296 * added TODO issue link
1 parent a0993e6 commit 12fed2e

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

BUILD

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,11 @@ licenses(["notice"]) # Apache 2.0
1919
exports_files([
2020
"LICENSE",
2121
])
22+
23+
cc_library(
24+
name = "spanner_client",
25+
includes = ["."],
26+
deps = [
27+
"//google/cloud/spanner:spanner_client",
28+
],
29+
)

google/cloud/spanner/BUILD

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15+
# TODO(#1415) Change this visibility to "//:__subpackages__" so that users are
16+
# required to use the top-level BUILD file rather than reaching down into this
17+
# one.
1518
package(default_visibility = ["//visibility:public"])
1619

1720
licenses(["notice"]) # Apache 2.0

0 commit comments

Comments
 (0)