Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Commit 8a0b81b

Browse files
authored
ci: upgrade builds to use Bazel 1.0 (#1004)
Now that Bazel reached 1.0 and it is expected to follow semver, it seems better to test with that version. The downside is that we may not notice breakage for users in the 0.28.0-0.29.0 range. But it seems that Bazel users are rapidly moving towards using 1.0 anyway. Apparently Bazel-1.0 cannot build gRPC with Clang-3.8 on Ubuntu-16.04. I am not sure which of those version numbers is the critical one, but don't care. The goal is to test our code with Clang-3.8, so using Bazel or CMake does not matter to us.
1 parent 8a1d9f1 commit 8a0b81b

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

ci/install-bazel.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ set -eu
1818
readonly PLATFORM=$(printf "%s-%s" "$(uname -s)" "$(uname -m)" \
1919
| tr '[:upper:]' '[:lower:]')
2020

21-
readonly BAZEL_VERSION="0.28.0"
21+
readonly BAZEL_VERSION="1.0.0"
2222
readonly GITHUB_DL="https://github.com/bazelbuild/bazel/releases/download"
2323
readonly SCRIPT_NAME="bazel-${BAZEL_VERSION}-installer-${PLATFORM}.sh"
2424
wget -q "${GITHUB_DL}/${BAZEL_VERSION}/${SCRIPT_NAME}"

ci/kokoro/docker/build.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -152,6 +152,8 @@ elif [[ "${BUILD_NAME}" = "clang-3.8" ]]; then
152152
export DISTRO_VERSION=16.04
153153
export CC=clang
154154
export CXX=clang++
155+
export CMAKE_SOURCE_DIR="super"
156+
in_docker_script="ci/kokoro/docker/build-in-docker-cmake.sh"
155157
elif [[ "${BUILD_NAME}" = "cxx17" ]]; then
156158
export GOOGLE_CLOUD_CPP_CXX_STANDARD=17
157159
export DISTRO=fedora-install

0 commit comments

Comments
 (0)