Skip to content
This repository was archived by the owner on Dec 8, 2021. It is now read-only.

Commit df09b74

Browse files
authored
bug: disable benchmark smoke tests (#1120)
The smoke tests are performing too many admin operations (basically CREATE TABLE), to the point where they exceed the project quota and the integration tests flake.
1 parent a221df7 commit df09b74

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

google/cloud/spanner/benchmarks/multiple_rows_cpu_benchmark.cc

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1031,7 +1031,7 @@ class RunAllExperiment : public Experiment {
10311031
Status SetUp(Config const&, cs::Database const&) override { return {}; }
10321032
Status TearDown(Config const&, cs::Database const&) override { return {}; }
10331033

1034-
Status Run(Config const& cfg, cs::Database const& database) override {
1034+
Status Run(Config const& cfg, cs::Database const& /*database*/) override {
10351035
// Smoke test all the experiments by running a very small version of each.
10361036

10371037
std::vector<std::future<google::cloud::Status>> tasks;
@@ -1051,10 +1051,12 @@ class RunAllExperiment : public Experiment {
10511051

10521052
auto experiment = kv.second(generator_);
10531053

1054+
// TODO(#1119) - tests disabled until we can stay within admin op quota
1055+
#if 0
10541056
tasks.push_back(std::async(
10551057
std::launch::async,
1056-
[](Config config, cs::Database const& database, std::mutex& mu,
1057-
std::unique_ptr<Experiment> experiment) {
1058+
[](Config config, cs::Database const& database,
1059+
std::mutex& mu, std::unique_ptr<Experiment> experiment) {
10581060
{
10591061
std::lock_guard<std::mutex> lk(mu);
10601062
std::cout << "# Smoke test for experiment\n";
@@ -1074,6 +1076,7 @@ class RunAllExperiment : public Experiment {
10741076
return google::cloud::Status();
10751077
},
10761078
config, database, std::ref(mu_), std::move(experiment)));
1079+
#endif
10771080
}
10781081

10791082
Status status;

google/cloud/spanner/benchmarks/single_row_throughput_benchmark.cc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -703,8 +703,8 @@ class RunAllExperiment : public Experiment {
703703
public:
704704
void SetUp(Config const&, cloud_spanner::Database const&) override {}
705705

706-
void Run(Config const& cfg, cloud_spanner::Database const& database,
707-
SampleSink const& sink) override {
706+
void Run(Config const& cfg, cloud_spanner::Database const& /*database*/,
707+
SampleSink const&) override {
708708
// Smoke test all the experiments by running a very small version of each.
709709
for (auto& kv : AvailableExperiments()) {
710710
// Do not recurse, skip this experiment.
@@ -714,8 +714,11 @@ class RunAllExperiment : public Experiment {
714714
config.samples = 1;
715715
config.iteration_duration = std::chrono::seconds(1);
716716
std::cout << "# Smoke test for experiment: " << kv.first << "\n";
717+
// TODO(#1119) - tests disabled until we can stay within admin op quota
718+
#if 0
717719
kv.second->SetUp(config, database);
718720
kv.second->Run(config, database, sink);
721+
#endif
719722
}
720723
}
721724
};

0 commit comments

Comments
 (0)