Skip to content

Commit 001b996

Browse files
authored
ci(gcb): run slow spanner instance tests during coverage build (#6277)
Fixes: #6276
1 parent 20ecf30 commit 001b996

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

ci/cloudbuild/builds/coverage.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ mapfile -t args < <(bazel::common_args)
2727
args+=("--instrumentation_filter=/google/cloud[/:],/generator[/:]")
2828
args+=("--instrument_test_targets")
2929
bazel coverage "${args[@]}" --test_tag_filters=-integration-test ...
30+
GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS="instance"
3031
mapfile -t integration_args < <(integration::args)
3132
integration::bazel_with_emulators coverage "${args[@]}" "${integration_args[@]}"
3233

ci/cloudbuild/builds/lib/integration.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,7 @@ function integration::args() {
7373
"--test_env=GOOGLE_CLOUD_CPP_STORAGE_TEST_SIGNING_KEYFILE=${PROJECT_ROOT}/google/cloud/storage/tests/test_service_account.not-a-test.json"
7474
"--test_env=GOOGLE_CLOUD_CPP_STORAGE_TEST_SIGNING_CONFORMANCE_FILENAME=${PROJECT_ROOT}/google/cloud/storage/tests/v4_signatures.json"
7575
# Spanner
76+
"--test_env=GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS=${GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS:-}"
7677
"--test_env=GOOGLE_CLOUD_CPP_SPANNER_TEST_INSTANCE_ID=${GOOGLE_CLOUD_CPP_SPANNER_TEST_INSTANCE_ID}"
7778
"--test_env=GOOGLE_CLOUD_CPP_SPANNER_TEST_SERVICE_ACCOUNT=${GOOGLE_CLOUD_CPP_SPANNER_TEST_SERVICE_ACCOUNT}"
7879
)
@@ -150,7 +151,6 @@ function integration::bazel_with_emulators() {
150151
bazel "${verb}" "${args[@]}"
151152

152153
# TODO(#6083): Add support for:
153-
# - GOOGLE_CLOUD_CPP_SPANNER_SLOW_INTEGRATION_TESTS
154154
# - GOOGLE_CLOUD_CPP_SPANNER_DEFAULT_ENDPOINT
155155
io::log_h2 "Running Spanner integration tests"
156156
bazel "${verb}" "${args[@]}" --test_tag_filters=integration-test \

0 commit comments

Comments
 (0)