fix generator in clang-tidy-tools build

Author: scotthart

external/googleapis/CMakeLists.txt

@@ -333,7 +333,7 @@ external_googleapis_add_library("google/rpc/status.proto"
 
 external_googleapis_add_library(
     "google/longrunning/operations.proto" api_annotations_protos
-    api_client_protos rpc_status_protos)
+    api_client_protos rpc_status_protos api_field_behavior_protos)
 
 external_googleapis_add_library(
     "google/iam/v1/iam_policy.proto"

generator/CMakeLists.txt

@@ -154,6 +154,7 @@ target_link_libraries(
            nlohmann_json::nlohmann_json
            google-cloud-cpp::api_client_protos
            google-cloud-cpp::api_field_info_protos
+           google-cloud-cpp::api_field_behavior_protos
            google-cloud-cpp::api_routing_protos
            google-cloud-cpp::cloud_extended_operations_protos
            google-cloud-cpp::longrunning_operations_protos

generator/internal/http_option_utils.cc

@@ -220,7 +220,8 @@ absl::optional<QueryParameterInfo> DetermineQueryParameterInfo(
         field.containing_type()->full_name() ==
             "google.longrunning.ListOperationsRequest") {
       return param_info;
-    } else if (field.cpp_type() != protobuf::FieldDescriptor::CPPTYPE_MESSAGE) {
+    }
+    if (field.cpp_type() != protobuf::FieldDescriptor::CPPTYPE_MESSAGE) {
       param_info = QueryParameterInfo{
           field.cpp_type(), absl::StrCat("request.", field.name(), "()"),
           false};