cleanup(common): make Idempotency enum public (#8049)

Author: coryan

generator/integration_tests/golden/golden_kitchen_sink_connection_idempotency_policy.cc

@@ -25,7 +25,7 @@ namespace cloud {
 namespace golden {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
-using ::google::cloud::internal::Idempotency;
+using ::google::cloud::Idempotency;
 
 GoldenKitchenSinkConnectionIdempotencyPolicy::~GoldenKitchenSinkConnectionIdempotencyPolicy() = default;
 

generator/integration_tests/golden/golden_kitchen_sink_connection_idempotency_policy.h

@@ -19,8 +19,8 @@
 #ifndef GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_GOLDEN_KITCHEN_SINK_CONNECTION_IDEMPOTENCY_POLICY_H
 #define GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_GOLDEN_KITCHEN_SINK_CONNECTION_IDEMPOTENCY_POLICY_H
 
+#include "google/cloud/idempotency.h"
 #include "google/cloud/internal/retry_policy.h"
-#include "google/cloud/status_or.h"
 #include "google/cloud/version.h"
 #include <generator/integration_tests/test.grpc.pb.h>
 #include <memory>
@@ -37,22 +37,22 @@ class GoldenKitchenSinkConnectionIdempotencyPolicy {
   /// Create a new copy of this object.
   virtual std::unique_ptr<GoldenKitchenSinkConnectionIdempotencyPolicy> clone() const = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GenerateAccessToken(google::test::admin::database::v1::GenerateAccessTokenRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GenerateIdToken(google::test::admin::database::v1::GenerateIdTokenRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   WriteLogEntries(google::test::admin::database::v1::WriteLogEntriesRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListLogs(google::test::admin::database::v1::ListLogsRequest request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListServiceAccountKeys(google::test::admin::database::v1::ListServiceAccountKeysRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   DoNothing(google::protobuf::Empty const& request) = 0;
 };
 

generator/integration_tests/golden/golden_thing_admin_connection_idempotency_policy.cc

@@ -25,7 +25,7 @@ namespace cloud {
 namespace golden {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
-using ::google::cloud::internal::Idempotency;
+using ::google::cloud::Idempotency;
 
 GoldenThingAdminConnectionIdempotencyPolicy::~GoldenThingAdminConnectionIdempotencyPolicy() = default;
 

generator/integration_tests/golden/golden_thing_admin_connection_idempotency_policy.h

@@ -19,9 +19,8 @@
 #ifndef GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_GOLDEN_THING_ADMIN_CONNECTION_IDEMPOTENCY_POLICY_H
 #define GOOGLE_CLOUD_CPP_GENERATOR_INTEGRATION_TESTS_GOLDEN_GOLDEN_THING_ADMIN_CONNECTION_IDEMPOTENCY_POLICY_H
 
-#include "google/cloud/future.h"
+#include "google/cloud/idempotency.h"
 #include "google/cloud/internal/retry_policy.h"
-#include "google/cloud/status_or.h"
 #include "google/cloud/version.h"
 #include <generator/integration_tests/test.grpc.pb.h>
 #include <memory>
@@ -38,58 +37,58 @@ class GoldenThingAdminConnectionIdempotencyPolicy {
   /// Create a new copy of this object.
   virtual std::unique_ptr<GoldenThingAdminConnectionIdempotencyPolicy> clone() const = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListDatabases(google::test::admin::database::v1::ListDatabasesRequest request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   CreateDatabase(google::test::admin::database::v1::CreateDatabaseRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GetDatabase(google::test::admin::database::v1::GetDatabaseRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   UpdateDatabaseDdl(google::test::admin::database::v1::UpdateDatabaseDdlRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   DropDatabase(google::test::admin::database::v1::DropDatabaseRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GetDatabaseDdl(google::test::admin::database::v1::GetDatabaseDdlRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   SetIamPolicy(google::iam::v1::SetIamPolicyRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GetIamPolicy(google::iam::v1::GetIamPolicyRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   TestIamPermissions(google::iam::v1::TestIamPermissionsRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   CreateBackup(google::test::admin::database::v1::CreateBackupRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   GetBackup(google::test::admin::database::v1::GetBackupRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   UpdateBackup(google::test::admin::database::v1::UpdateBackupRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   DeleteBackup(google::test::admin::database::v1::DeleteBackupRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListBackups(google::test::admin::database::v1::ListBackupsRequest request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   RestoreDatabase(google::test::admin::database::v1::RestoreDatabaseRequest const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListDatabaseOperations(google::test::admin::database::v1::ListDatabaseOperationsRequest request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   ListBackupOperations(google::test::admin::database::v1::ListBackupOperationsRequest request) = 0;
 
-  virtual google::cloud::internal::Idempotency
+  virtual google::cloud::Idempotency
   LongRunningWithoutRouting(google::test::admin::database::v1::RestoreDatabaseRequest const& request) = 0;
 };
 

generator/integration_tests/golden/tests/golden_kitchen_sink_idempotency_policy_test.cc

@@ -22,7 +22,7 @@ namespace golden_internal {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::internal::Idempotency;
+using ::google::cloud::Idempotency;
 
 class GoldenKitchenSinkIdempotencyPolicyTest : public ::testing::Test {
  protected:

generator/integration_tests/golden/tests/golden_thing_admin_idempotency_policy_test.cc

@@ -22,7 +22,7 @@ namespace golden_internal {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::internal::Idempotency;
+using ::google::cloud::Idempotency;
 namespace gtab = ::google::test::admin::database::v1;
 
 class GoldenIdempotencyPolicyTest : public ::testing::Test {

generator/internal/idempotency_policy_generator.cc

@@ -49,9 +49,9 @@ Status IdempotencyPolicyGenerator::GenerateHeader() {
 
   // includes
   HeaderPrint("\n");
-  HeaderLocalIncludes({HasLongrunningMethod() ? "google/cloud/future.h" : "",
+  HeaderLocalIncludes({"google/cloud/idempotency.h",
                        "google/cloud/internal/retry_policy.h",
-                       "google/cloud/status_or.h", "google/cloud/version.h"});
+                       "google/cloud/version.h"});
   HeaderSystemIncludes({vars("proto_grpc_header_path"), "memory"});
 
   auto result = HeaderOpenNamespaces();
@@ -78,7 +78,7 @@ Status IdempotencyPolicyGenerator::GenerateHeader() {
              {
                  // clang-format off
    {"\n"
-    "  virtual google::cloud::internal::Idempotency\n"
+    "  virtual google::cloud::Idempotency\n"
     "  $method_name$($request_type$ const& request) = 0;\n"}
                  // clang-format on
              },
@@ -87,7 +87,7 @@ Status IdempotencyPolicyGenerator::GenerateHeader() {
              {
                  // clang-format off
    {"\n"
-    "  virtual google::cloud::internal::Idempotency\n"
+    "  virtual google::cloud::Idempotency\n"
     "  $method_name$($request_type$ request) = 0;\n"}
                  // clang-format on
              },
@@ -130,7 +130,7 @@ Status IdempotencyPolicyGenerator::GenerateCc() {
   auto result = CcOpenNamespaces();
   if (!result.ok()) return result;
 
-  CcPrint("\nusing ::google::cloud::internal::Idempotency;\n");
+  CcPrint("\nusing ::google::cloud::Idempotency;\n");
 
   CcPrint(  // clang-format off
     "\n$idempotency_class_name$::~$idempotency_class_name$() = default;\n");

google/cloud/CMakeLists.txt

@@ -61,6 +61,7 @@ add_library(
     iam_bindings.h
     iam_policy.cc
     iam_policy.h
+    idempotency.h
     internal/absl_str_cat_quiet.h
     internal/absl_str_join_quiet.h
     internal/absl_str_replace_quiet.h

google/cloud/accessapproval/access_approval_connection_idempotency_policy.cc

@@ -25,7 +25,7 @@ namespace cloud {
 namespace accessapproval {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 
-using ::google::cloud::internal::Idempotency;
+using ::google::cloud::Idempotency;
 
 AccessApprovalConnectionIdempotencyPolicy::
     ~AccessApprovalConnectionIdempotencyPolicy() = default;

google/cloud/accessapproval/access_approval_connection_idempotency_policy.h

@@ -19,8 +19,8 @@
 #ifndef GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_ACCESSAPPROVAL_ACCESS_APPROVAL_CONNECTION_IDEMPOTENCY_POLICY_H
 #define GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_ACCESSAPPROVAL_ACCESS_APPROVAL_CONNECTION_IDEMPOTENCY_POLICY_H
 
+#include "google/cloud/idempotency.h"
 #include "google/cloud/internal/retry_policy.h"
-#include "google/cloud/status_or.h"
 #include "google/cloud/version.h"
 #include <google/cloud/accessapproval/v1/accessapproval.grpc.pb.h>
 #include <memory>
@@ -38,31 +38,31 @@ class AccessApprovalConnectionIdempotencyPolicy {
   virtual std::unique_ptr<AccessApprovalConnectionIdempotencyPolicy> clone()
       const = 0;
 
-  virtual google::cloud::internal::Idempotency ListApprovalRequests(
+  virtual google::cloud::Idempotency ListApprovalRequests(
       google::cloud::accessapproval::v1::ListApprovalRequestsMessage
           request) = 0;
 
-  virtual google::cloud::internal::Idempotency GetApprovalRequest(
+  virtual google::cloud::Idempotency GetApprovalRequest(
       google::cloud::accessapproval::v1::GetApprovalRequestMessage const&
           request) = 0;
 
-  virtual google::cloud::internal::Idempotency ApproveApprovalRequest(
+  virtual google::cloud::Idempotency ApproveApprovalRequest(
       google::cloud::accessapproval::v1::ApproveApprovalRequestMessage const&
           request) = 0;
 
-  virtual google::cloud::internal::Idempotency DismissApprovalRequest(
+  virtual google::cloud::Idempotency DismissApprovalRequest(
       google::cloud::accessapproval::v1::DismissApprovalRequestMessage const&
           request) = 0;
 
-  virtual google::cloud::internal::Idempotency GetAccessApprovalSettings(
+  virtual google::cloud::Idempotency GetAccessApprovalSettings(
       google::cloud::accessapproval::v1::GetAccessApprovalSettingsMessage const&
           request) = 0;
 
-  virtual google::cloud::internal::Idempotency UpdateAccessApprovalSettings(
+  virtual google::cloud::Idempotency UpdateAccessApprovalSettings(
       google::cloud::accessapproval::v1::
           UpdateAccessApprovalSettingsMessage const& request) = 0;
 
-  virtual google::cloud::internal::Idempotency DeleteAccessApprovalSettings(
+  virtual google::cloud::Idempotency DeleteAccessApprovalSettings(
       google::cloud::accessapproval::v1::
           DeleteAccessApprovalSettingsMessage const& request) = 0;
 };