Skip to content

Commit 072f22d

Browse files
committed
add omission rationale
1 parent f10480f commit 072f22d

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

generator/standalone_main.cc

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,13 @@ std::vector<std::future<google::cloud::Status>> GenerateCodeFromProtos(
233233
GenerateScaffold(scaffold_vars, generator_args.scaffold_templates_path,
234234
generator_args.output_path, service);
235235
} else {
236+
// Bigtable, pubsub, and spanner, have their admin services generated but
237+
// their data services handwritten. The dox files for these are also
238+
// handwritten, so we don't want to overwrite them with generated ones.
239+
//
240+
// Compute is a special case that has almost a hundred generated services,
241+
// but the dox files are not per service, but are all under the compute
242+
// umbrella which has one set of dox files intended to cover all of them.
236243
static constexpr std::array<char const*, 4> kOmittedDocDirs = {
237244
"google/cloud/bigtable", "google/cloud/compute",
238245
"google/cloud/pubsub", "google/cloud/spanner"};

0 commit comments

Comments
 (0)