fixing tests

Author: shubham-up-47

google/cloud/storage/internal/async/connection_impl_open_test.cc

@@ -202,6 +202,12 @@ TEST(AsyncConnectionImplTest, OpenSimple) {
       });
 
   auto mock_cq = std::make_shared<MockCompletionQueueImpl>();
+  EXPECT_CALL(*mock_cq, MakeRelativeTimer)
+      .WillRepeatedly([](std::chrono::nanoseconds) {
+        return make_ready_future(
+            StatusOr<std::chrono::system_clock::time_point>(
+                std::chrono::system_clock::now()));
+      });
   auto connection = std::make_shared<AsyncConnectionImpl>(
       CompletionQueue(mock_cq), std::shared_ptr<GrpcChannelRefresh>(), mock,
       TestOptions());

google/cloud/storage/internal/async/object_descriptor_impl.cc

@@ -93,6 +93,7 @@ void ObjectDescriptorImpl::MakeSubsequentStream() {
   }
   // Proactively create a new stream if needed.
   AssurePendingStreamQueued();
+  if (!pending_stream_.valid()) return;
   auto stream_future = std::move(pending_stream_);
   lk.unlock();
 

google/cloud/storage/internal/async/object_descriptor_impl_test.cc

@@ -1580,7 +1580,7 @@ TEST(ObjectDescriptorImpl, OnResumeSuccessful) {
     auto e1 = seq.PopFrontWithName();
     auto e2 = seq.PopFrontWithName();
     std::set<std::string> names = {e1.second, e2.second};
-    if (names.count("Read[1]") && names.count("ProactiveFactory")) {
+    if (names.count("Read[1]") != 0 && names.count("ProactiveFactory") != 0) {
       e1.first.set_value(true);  // Allow read to proceed
       e2.first.set_value(true);  // Allow factory to proceed
     } else {