adding tests

Author: shubham-up-47

google/cloud/opentelemetry/internal/monitoring_exporter.cc

@@ -36,7 +36,7 @@ otel_internal::ResourceFilterDataFn MakeFilter(Options const& options) {
     return nullptr;
   }
 
-  // Get the excluded labels list.
+  // Get the metric labels set to be excluded.
   auto const& excluded = options.get<otel::ResourceFilterDataFnOption>();
   if (excluded.empty()) return nullptr;
 

google/cloud/opentelemetry/internal/monitoring_exporter.h

@@ -51,7 +51,8 @@ class MonitoringExporter final
   MonitoringExporter(
       std::shared_ptr<monitoring_v3::MetricServiceConnection> conn,
       otel_internal::MonitoredResourceFromDataFn dynamic_resource_fn,
-      otel_internal::ResourceFilterDataFn resource_filter_fn, Options const& options);
+      otel_internal::ResourceFilterDataFn resource_filter_fn,
+      Options const& options);
 
   MonitoringExporter(
       Project project,

google/cloud/opentelemetry/internal/monitoring_exporter_test.cc

@@ -159,6 +159,39 @@ TEST(MonitoringExporter, ExportSuccess) {
   EXPECT_EQ(result, opentelemetry::sdk::common::ExportResult::kSuccess);
 }
 
+TEST(MonitoringExporterTest, MakeFilterNoOption) {
+  auto mock =
+      std::make_shared<monitoring_v3_mocks::MockMetricServiceConnection>();
+  Options options;
+
+  auto exporter = std::make_unique<MonitoringExporter>(Project("test-project"),
+                                                       mock, options);
+  EXPECT_NE(exporter, nullptr);
+}
+
+TEST(MonitoringExporterTest, MakeFilterEmptySet) {
+  auto mock =
+      std::make_shared<monitoring_v3_mocks::MockMetricServiceConnection>();
+  Options options;
+  options.set<otel::ResourceFilterDataFnOption>(std::set<std::string>{});
+
+  auto exporter = std::make_unique<MonitoringExporter>(Project("test-project"),
+                                                       mock, options);
+  EXPECT_NE(exporter, nullptr);
+}
+
+TEST(MonitoringExporterTest, MakeFilterWithExcludedKeys) {
+  auto mock =
+      std::make_shared<monitoring_v3_mocks::MockMetricServiceConnection>();
+  Options options;
+  std::set<std::string> excluded{"service_name", "service_version"};
+  options.set<otel::ResourceFilterDataFnOption>(excluded);
+
+  auto exporter = std::make_unique<MonitoringExporter>(Project("test-project"),
+                                                       mock, options);
+  EXPECT_NE(exporter, nullptr);
+}
+
 }  // namespace
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
 }  // namespace otel_internal

google/cloud/storage/grpc_plugin.h

@@ -136,7 +136,7 @@ struct GrpcMetricsExportTimeoutOption {
  *
  * A set of OpenTelemetry resource attribute keys to exclude from metric labels
  * when exporting gRPC telemetry. For example, to exclude the `service.name`
- * label, configure the option with `{"service.name"}`.
+ * label, configure the option with `{"service_name"}`.
  *
  * @par Example: Exclude specific labels from telemetry
  * @code