impl(bigtable): populate Value proto with Type for parameters (#15752)

Author: scotthart

google/cloud/bigtable/bound_query.cc

@@ -35,10 +35,12 @@ google::bigtable::v2::ExecuteQueryRequest BoundQuery::ToRequestProto() const {
 
   google::protobuf::Map<std::string, google::bigtable::v2::Value> parameters;
   for (auto const& kv : parameters_) {
-    parameters[kv.first] =
-        bigtable_internal::ValueInternals::ToProto(kv.second).second;
+    auto type_value = bigtable_internal::ValueInternals::ToProto(kv.second);
+    google::bigtable::v2::Value v = std::move(type_value.second);
+    *v.mutable_type() = std::move(type_value.first);
+    parameters[kv.first] = std::move(v);
   }
-  *result.mutable_params() = parameters;
+  *result.mutable_params() = std::move(parameters);
   return result;
 }
 

google/cloud/bigtable/bound_query_test.cc

@@ -97,12 +97,14 @@ TEST(BoundQuery, ToRequestProto) {
   auto val1 = proto.params().find("val1")->second;
   EXPECT_TRUE(val1.has_bool_value());
   EXPECT_EQ(true, val1.bool_value());
+  EXPECT_TRUE(val1.type().has_bool_type());
 
   // The second parameter is a double.
   EXPECT_TRUE(proto.params().contains("val2"));
   auto val2 = proto.params().find("val2")->second;
   EXPECT_TRUE(val2.has_float_value());
   EXPECT_EQ(2.0, val2.float_value());
+  EXPECT_TRUE(val2.type().has_float64_type());
 
   // Cancel all pending operations, satisfying any remaining futures.
   fake_cq_impl->SimulateCompletion(false);