Integration test for InstanceAdmin::ListInstances. (#371)

This fixes #343.

Author: coryan

bigtable/tests/CMakeLists.txt

@@ -40,3 +40,10 @@ target_link_libraries(mutations_integration_test
         gmock bigtable_client bigtable_client_testing bigtable_protos
         gRPC::grpc protobuf::libprotobuf)
 add_dependencies(tests-local mutations_integration_test)
+
+# Integration tests for bigtable::InstanceAdmin.
+add_executable(instance_admin_integration_test instance_admin_integration_test.cc)
+target_link_libraries(instance_admin_integration_test PRIVATE
+    gmock bigtable_client bigtable_client_testing bigtable_protos
+    gRPC::grpc protobuf::libprotobuf)
+add_dependencies(tests-local instance_admin_integration_test)

bigtable/tests/instance_admin_integration_test.cc

@@ -0,0 +1,82 @@
+// Copyright 2018 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "bigtable/client/instance_admin.h"
+#include "bigtable/client/internal/make_unique.h"
+#include <gmock/gmock.h>
+
+namespace {
+class InstanceTestEnvironment : public ::testing::Environment {
+ public:
+  explicit InstanceTestEnvironment(std::string project) {
+    project_id_ = std::move(project);
+  }
+
+  static std::string const& project_id() { return project_id_; }
+
+ private:
+  static std::string project_id_;
+};
+
+std::string InstanceTestEnvironment::project_id_;
+
+class InstanceAdminIntegrationTest : public ::testing::Test {
+ protected:
+  void SetUp() override {
+    auto instance_admin_client = bigtable::CreateDefaultInstanceAdminClient(
+        InstanceTestEnvironment::project_id(), bigtable::ClientOptions());
+    instance_admin_ = bigtable::internal::make_unique<bigtable::InstanceAdmin>(
+        instance_admin_client);
+  }
+
+ protected:
+  std::unique_ptr<bigtable::InstanceAdmin> instance_admin_;
+};
+
+bool UsingCloudBigtableEmulator() {
+  return std::getenv("BIGTABLE_EMULATOR_HOST") != nullptr;
+}
+}  // namespace
+
+/// @test Verify that InstanceAdmin::ListInstances works as expected.
+TEST_F(InstanceAdminIntegrationTest, ListInstancesTest) {
+  // The emulator does not support instance operations.
+  if (UsingCloudBigtableEmulator()) {
+    return;
+  }
+  auto instances = instance_admin_->ListInstances();
+  for (auto const& i : instances) {
+    auto const npos = std::string::npos;
+    EXPECT_NE(npos, i.name().find(instance_admin_->project_name()));
+  }
+}
+
+int main(int argc, char* argv[]) {
+  ::testing::InitGoogleTest(&argc, argv);
+
+  if (argc != 2) {
+    std::string const cmd = argv[0];
+    auto last_slash = std::string(cmd).find_last_of('/');
+    // Show usage if number of arguments is invalid.
+    std::cerr << "Usage: " << cmd.substr(last_slash + 1) << " <project_id>"
+              << std::endl;
+    return 1;
+  }
+
+  std::string const project_id = argv[1];
+  (void)::testing::AddGlobalTestEnvironment(
+      new InstanceTestEnvironment(project_id));
+
+  return RUN_ALL_TESTS();
+}

bigtable/tests/integration_tests_utils.sh

@@ -51,6 +51,10 @@ function run_all_integration_tests() {
     instance_id=$1
   fi
 
+  echo
+  echo "Running bigtable::InstanceAdmin integration test."
+  ./instance_admin_integration_test "${project_id}"
+
   echo
   echo "Running bigtable::TableAdmin integration test."
   delete_all_tables "${project_id}" "${instance_id:-}"