Skip to content

Commit 352d941

Browse files
authored
Merge branch 'prepare-for-v3.0.0' into remove-client-options
2 parents 993a88a + d0db317 commit 352d941

File tree

4 files changed

+12
-47
lines changed

4 files changed

+12
-47
lines changed

doc/v3-migration-guide.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -215,6 +215,18 @@ auto client = bigtable::CreateDefaultInstanceAdminClient(
215215
auto client = bigtable::MakeInstanceAdminClient(
216216
"my-project",
217217
google::cloud::Options{}.set<google::cloud::GrpcNumChannelsOption>(4));
218+
<summary>Removed <code>bigtable::AsyncRowReader<>::NO_ROWS_LIMIT</code>
219+
</summary>
220+
221+
AsyncRowReader::NO_ROWS_LIMIT has been removed. Please use
222+
`google::cloud::bigtable::RowReader::NO_ROWS_LIMIT` instead.
223+
224+
```cpp
225+
// Before
226+
auto limit = google::cloud::bigtable::AsyncRowReader<>::NO_ROWS_LIMIT;
227+
228+
// After
229+
auto limit = google::cloud::bigtable::RowReader::NO_ROWS_LIMIT;
218230
```
219231

220232
</details>

google/cloud/bigtable/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,6 @@ add_library(
108108
admin_client.h
109109
app_profile_config.cc
110110
app_profile_config.h
111-
async_row_reader.h
112111
bound_query.cc
113112
bound_query.h
114113
bytes.cc

google/cloud/bigtable/async_row_reader.h

Lines changed: 0 additions & 45 deletions
This file was deleted.

google/cloud/bigtable/google_cloud_cpp_bigtable.bzl

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ google_cloud_cpp_bigtable_hdrs = [
4747
"admin/internal/bigtable_table_admin_tracing_stub.h",
4848
"admin_client.h",
4949
"app_profile_config.h",
50-
"async_row_reader.h",
5150
"bound_query.h",
5251
"bytes.h",
5352
"cell.h",

0 commit comments

Comments
 (0)