feat(storage): promote gRPC plugin to GA (#14712)

* feat(storage): promote gRPC plugin to GA

Move the gRPC plugin functions out of the
`google::cloud::storage_experimental` namespace and remove the
`experimental-` prefix from the CMake and Bazel targets. I left shims in
place for backwards compatibility.

The `AsyncClient` remains in the `storage_experimental` namespace, it is
fully functional, but we may change some APIs.

* continue from Carlos previous work

* remove duplicate entry in readme

* fix typo in cmake-split-install.sh

* remove storage_control from transitional

* remove more references to experimental-storage_grpc

* fix naming in storage_grpc.cmake

* more grpc build fixes

* update store_grpc abi dump

* change naming in quickstart build, remove more experimental references

* checkers

* fix quickstart

* update customer facing references to direct path

* feedback

* checkers

* remove inline from header and implement in .cc

* add todo to storage/quickstart/build.bazel

* checkers

* namesapce

* remove newline

* fix namespace to exeperimental

* update libraries.bzl

* checkers

---------

Co-authored-by: Carlos O'Ryan <[email protected]>

Author: ddelgrosso1

BUILD.bazel

@@ -153,6 +153,23 @@ bool_flag(
     visibility = ["//:__subpackages__"],
 )
 
+cc_library(
+    name = "storage_grpc",
+    hdrs = ["//google/cloud/storage:public_grpc_hdrs"],
+    deps = [
+        "//google/cloud/storage:google_cloud_cpp_storage_grpc",
+    ],
+)
+
+cc_library(
+    name = "storage_grpc_mocks",
+    testonly = True,
+    hdrs = ["//google/cloud/storage:grpc_mocks_hdrs"],
+    deps = [
+        "//google/cloud/storage:google_cloud_cpp_storage_grpc_mocks",
+    ],
+)
+
 cc_library(
     name = "experimental-storage_grpc",
     hdrs = ["//google/cloud/storage:public_grpc_hdrs"],

CHANGELOG.md

@@ -20,6 +20,12 @@ breaking changes in the upcoming 3.x release. This release is scheduled for
   using this API, and therefore we do not consider this a breaking change.
   ([#14726](https://github.com/googleapis/google-cloud-cpp/pull/14726))
 
+### [Google Cloud Storage](/google/cloud/storage/README.md)
+
+- The gRPC plugin is now GA. The [Using the gRPC plugin][storage-grpc]
+  guide describes this feature in more detail. When using GCS from Google
+  Compute Engine (GCE) this plugin can enable higher total throughput.
+
 ## v2.29.0 - 2024-09
 
 ### New Libraries
@@ -1810,3 +1816,4 @@ case it elicits some feedback that requires changes.
 [product-launch-stages]: https://cloud.google.com/products/#product-launch-stages
 [resource-manager-tags]: https://cloud.google.com/resource-manager/docs/tags/tags-overview
 [speech-model-adaptation]: https://cloud.google.com/speech-to-text/docs/adaptation-model
+[storage-grpc]: https://cloud.google.com/cpp/docs/reference/storage/latest/storage-grpc

README.md

@@ -39,12 +39,9 @@ int main(int argc, char* argv[]) {
   }
   std::string const bucket_name = argv[1];
 
-  // Create aliases to make the code easier to read.
-  namespace gcs = ::google::cloud::storage;
-
   // Create a client to communicate with Google Cloud Storage. This client
   // uses the default configuration for authentication and project id.
-  auto client = gcs::Client();
+  auto client = google::cloud::storage::Client();
 
   auto writer = client.WriteObject(bucket_name, "quickstart.txt");
   writer << "Hello World!";

ci/abi-dumps/google_cloud_cpp_storage_grpc.expected.abi.dump.gz

@@ -211,6 +211,9 @@ time {
 
   mapfile -t libraries < <(features::libraries)
   for library in "${libraries[@]}" opentelemetry; do
+    if [[ "${library}" == "storage_grpc" ]]; then
+      continue
+    fi
     ci/generate-markdown/update-library-readme.sh "${library}"
   done
 }

ci/cloudbuild/builds/checkers.sh

@@ -228,7 +228,7 @@ cmake -G Ninja \
   -S "${PROJECT_ROOT}/ci/verify_quickstart" \
   -B "${PROJECT_ROOT}/cmake-out/quickstart" \
   "-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX}" \
-  "-DFEATURES=experimental-storage_grpc"
+  "-DFEATURES=storage_grpc"
 cmake --build "${PROJECT_ROOT}/cmake-out/quickstart"
 
 io::log_h2 "Delete installed artifacts and run compiled quickstarts"

ci/cloudbuild/builds/cmake-install.sh

@@ -50,7 +50,7 @@ io::log_h2 "Building and installing popular libraries"
 mapfile -t core_cmake_args < <(cmake::common_args cmake-out/popular-libraries)
 io::run cmake "${core_cmake_args[@]}" "${install_args[@]}" \
   -DCMAKE_PREFIX_PATH="${INSTALL_PREFIX}" \
-  -DGOOGLE_CLOUD_CPP_ENABLE="bigtable,pubsub,spanner,storage,iam,policytroubleshooter" \
+  -DGOOGLE_CLOUD_CPP_ENABLE="bigtable,pubsub,spanner,storage,storage_grpc,iam,policytroubleshooter" \
   -DGOOGLE_CLOUD_CPP_USE_INSTALLED_COMMON=ON
 io::run cmake --build cmake-out/popular-libraries
 io::run cmake --install cmake-out/popular-libraries --prefix "${INSTALL_PREFIX}"
@@ -71,13 +71,13 @@ mapfile -t feature_cmake_args < <(cmake::common_args cmake-out/features)
 io::run cmake "${feature_cmake_args[@]}" "${install_args[@]}" \
   -DCMAKE_PREFIX_PATH="${INSTALL_PREFIX}" \
   -DGOOGLE_CLOUD_CPP_USE_INSTALLED_COMMON=ON \
-  -DGOOGLE_CLOUD_CPP_ENABLE="__ga_libraries__,-bigtable,-pubsub,-storage,-spanner,-iam,-policytroubleshooter,-compute"
+  -DGOOGLE_CLOUD_CPP_ENABLE="__ga_libraries__,-bigtable,-pubsub,-storage,-storage_grpc,-spanner,-iam,-policytroubleshooter,-compute"
 io::run cmake --build cmake-out/features
 io::run cmake --install cmake-out/features --prefix "${INSTALL_PREFIX}"
 
 # Tests the installed artifacts by building all the quickstarts.
 # shellcheck disable=SC2046
-mapfile -t feature_list < <(cmake -P cmake/print-ga-features.cmake 2>&1)
+mapfile -t feature_list < <(cmake -P cmake/print-ga-features.cmake 2>&1 | grep -v storage_grpc)
 FEATURES=$(printf ";%s" "${feature_list[@]}")
 FEATURES="${FEATURES:1}"
 io::run cmake -G Ninja \

ci/cloudbuild/builds/cmake-split-install.sh

@@ -41,7 +41,7 @@ function features::always_build() {
     # library instrumentation, and the GCP exporters.
     opentelemetry
     # Enable storage_grpc in most builds.
-    experimental-storage_grpc
+    storage_grpc
   )
   printf "%s\n" "${list[@]}" | sort -u
 }
@@ -62,7 +62,6 @@ function features::libraries() {
 function features::_internal_extra() {
   local list=(
     experimental-bigquery_rest
-    experimental-storage_grpc
     opentelemetry
   )
   printf "%s\n" "${list[@]}"

ci/cloudbuild/builds/lib/features.sh

@@ -101,12 +101,12 @@ function quickstart::run_gcs_grpc_quickstart() {
   io::log_h2 "Running quickstart for GCS+gRPC"
 
   io::log "[ CMake ]"
-  local cmake_bin_dir="${PROJECT_ROOT}/cmake-out/quickstart/cmake-storage"
+  local cmake_bin_dir="${PROJECT_ROOT}/cmake-out/quickstart/cmake-storage_grpc"
   "${cmake_bin_dir}/quickstart_grpc" "${run_args[@]}"
 
   echo
   io::log "[ Make ]"
-  local makefile_bin_dir="${PROJECT_ROOT}/cmake-out/quickstart/makefile-storage"
+  local makefile_bin_dir="${PROJECT_ROOT}/cmake-out/quickstart/makefile-storage_grpc"
   LD_LIBRARY_PATH="${prefix}/lib64:${prefix}/lib:${LD_LIBRARY_PATH:-}" \
     "${makefile_bin_dir}/quickstart_grpc" "${run_args[@]}"
 }

ci/cloudbuild/builds/lib/quickstart.sh

@@ -18,7 +18,7 @@
 ALWAYS_RESET_CMAKE_CACHE=NO
 
 # By default compile most features.
-ENABLED_FEATURES=__ga_libraries__,__experimental_libraries__,opentelemetry,experimental-storage_grpc
+ENABLED_FEATURES=__ga_libraries__,__experimental_libraries__,opentelemetry
 
 # By default compile all the code.
 BAZEL_TARGETS=("...")