cleanup: chrono literals (#14826)

dbolduc · web-flow · commit 4174d656136f · 2024-11-06T12:37:18.000-05:00
diff --git a/google/cloud/bigtable/column_family_test.cc b/google/cloud/bigtable/column_family_test.cc
@@ -22,12 +22,11 @@ namespace bigtable {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-// NOLINTNEXTLINE
-using ::google::cloud::testing_util::chrono_literals::operator"" _min;
-using ::google::cloud::testing_util::chrono_literals::operator"" _h;   // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _s;   // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _ns;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_min;
+using ::google::cloud::testing_util::chrono_literals::operator""_h;
+using ::google::cloud::testing_util::chrono_literals::operator""_s;
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
+using ::google::cloud::testing_util::chrono_literals::operator""_ns;
 
 TEST(GcRule, Equality) {
   auto gc1 = GcRule::MaxNumVersions(3);
diff --git a/google/cloud/bigtable/filters_test.cc b/google/cloud/bigtable/filters_test.cc
@@ -26,8 +26,8 @@ namespace {
 namespace btproto = ::google::bigtable::v2;
 
 using ::google::cloud::testing_util::IsProtoEqual;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 
 TEST(FiltersTest, Equality) {
   auto f1 = Filter::PassAllFilter();
diff --git a/google/cloud/bigtable/idempotent_mutation_policy_test.cc b/google/cloud/bigtable/idempotent_mutation_policy_test.cc
@@ -22,8 +22,8 @@ namespace bigtable {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 
 /// @test Verify that the default policy works as expected.
 TEST(IdempotentMutationPolicyTest, Simple) {
diff --git a/google/cloud/bigtable/internal/bulk_mutator_test.cc b/google/cloud/bigtable/internal/bulk_mutator_test.cc
@@ -27,7 +27,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
 namespace v2 = ::google::bigtable::v2;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::bigtable::testing::MockBigtableStub;
 using ::google::cloud::bigtable::testing::MockMutateRowsLimiter;
 using ::google::cloud::bigtable::testing::MockMutateRowsStream;
diff --git a/google/cloud/bigtable/internal/legacy_async_bulk_apply_test.cc b/google/cloud/bigtable/internal/legacy_async_bulk_apply_test.cc
@@ -36,7 +36,7 @@ namespace btproto = ::google::bigtable::v2;
 
 using ::google::cloud::bigtable::testing::MockBackoffPolicy;
 using ::google::cloud::bigtable::testing::MockClientAsyncReaderInterface;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::testing_util::FakeCompletionQueueImpl;
 using ::google::cloud::testing_util::StatusIs;
 
diff --git a/google/cloud/bigtable/internal/legacy_async_row_reader_test.cc b/google/cloud/bigtable/internal/legacy_async_row_reader_test.cc
@@ -37,7 +37,7 @@ namespace btproto = ::google::bigtable::v2;
 
 using ::google::cloud::bigtable::testing::MockClientAsyncReaderInterface;
 using ::google::cloud::testing_util::ValidateMetadataFixture;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::testing_util::FakeCompletionQueueImpl;
 using ::testing::HasSubstr;
 using ::testing::Values;
diff --git a/google/cloud/bigtable/internal/legacy_bulk_mutator_test.cc b/google/cloud/bigtable/internal/legacy_bulk_mutator_test.cc
@@ -27,7 +27,7 @@ namespace {
 
 namespace btproto = ::google::bigtable::v2;
 using ::testing::Return;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::bigtable::testing::MockMutateRowsReader;
 
 auto constexpr kTableName = "projects/blah/instances/blah2/tables/table";
diff --git a/google/cloud/bigtable/mutation_batcher_test.cc b/google/cloud/bigtable/mutation_batcher_test.cc
@@ -35,7 +35,7 @@ using ::google::cloud::bigtable_mocks::MockDataConnection;
 using ::google::cloud::testing_util::IsOk;
 using ::google::cloud::testing_util::IsProtoEqual;
 using ::google::cloud::testing_util::MockCompletionQueueImpl;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::testing::Not;
 using ::testing::Return;
 using ::testing::WithParamInterface;
diff --git a/google/cloud/bigtable/mutations_test.cc b/google/cloud/bigtable/mutations_test.cc
@@ -27,8 +27,8 @@ namespace {
 
 namespace btproto = ::google::bigtable::v2;
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 
 TEST(SingleRowMutation, Equality) {
   auto m1 = SingleRowMutation("m1", DeleteFromRow());
diff --git a/google/cloud/bigtable/polling_policy_test.cc b/google/cloud/bigtable/polling_policy_test.cc
@@ -43,7 +43,7 @@ grpc::Status GrpcTransientError() {
   return grpc::Status(grpc::StatusCode::UNAVAILABLE, "try again");
 }
 
-using testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using testing_util::chrono_literals::operator""_ms;
 auto const kLimitedTimeTestPeriod = 100_ms;
 auto const kLimitedTimeTolerance = 20_ms;
 
diff --git a/google/cloud/bigtable/rpc_backoff_policy_test.cc b/google/cloud/bigtable/rpc_backoff_policy_test.cc
@@ -24,7 +24,7 @@ namespace bigtable {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 
 /// Create a grpc::Status with a status code for transient errors.
 grpc::Status GrpcTransientError() {
diff --git a/google/cloud/bigtable/rpc_retry_policy_test.cc b/google/cloud/bigtable/rpc_retry_policy_test.cc
@@ -46,7 +46,7 @@ Status PermanentError() {
   return Status(StatusCode::kFailedPrecondition, "failed");
 }
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 
 auto const kLimitedTimeTestPeriod = 100_ms;
 auto const kLimitedTimeTolerance = 20_ms;
diff --git a/google/cloud/bigtable/table_apply_test.cc b/google/cloud/bigtable/table_apply_test.cc
@@ -28,7 +28,7 @@ namespace {
 namespace bigtable = ::google::cloud::bigtable;
 using ::google::cloud::testing_util::StatusIs;
 using ::google::cloud::testing_util::ValidateMetadataFixture;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 
 class TableApplyTest : public bigtable::testing::TableTestFixture {
  protected:
diff --git a/google/cloud/bigtable/table_bulk_apply_test.cc b/google/cloud/bigtable/table_bulk_apply_test.cc
@@ -29,8 +29,8 @@ namespace btproto = ::google::bigtable::v2;
 
 using ::google::cloud::bigtable::testing::MockBackoffPolicy;
 using ::google::cloud::testing_util::IsOk;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 using ::testing::An;
 using ::testing::Not;
 using ::testing::Return;
diff --git a/google/cloud/bigtable/table_check_and_mutate_row_test.cc b/google/cloud/bigtable/table_check_and_mutate_row_test.cc
@@ -26,7 +26,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
 using ::google::cloud::testing_util::ValidateMetadataFixture;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 
 class TableCheckAndMutateRowTest : public bigtable::testing::TableTestFixture {
  protected:
diff --git a/google/cloud/bigtable/table_sample_row_keys_test.cc b/google/cloud/bigtable/table_sample_row_keys_test.cc
@@ -25,7 +25,7 @@ namespace bigtable {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 using ::google::cloud::bigtable::testing::MockSampleRowKeysReader;
 using ::testing::Return;
 using ::testing::Unused;
diff --git a/google/cloud/bigtable/tests/data_async_future_integration_test.cc b/google/cloud/bigtable/tests/data_async_future_integration_test.cc
@@ -23,7 +23,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
 using ::google::cloud::bigtable::testing::TableIntegrationTest;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 
 class DataAsyncIntegrationTest
     : public TableIntegrationTest,
diff --git a/google/cloud/bigtable/tests/data_integration_test.cc b/google/cloud/bigtable/tests/data_integration_test.cc
@@ -29,7 +29,7 @@ namespace {
 
 using ::google::cloud::bigtable::testing::TableIntegrationTest;
 using ::google::cloud::bigtable::testing::TableTestEnvironment;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::std::chrono::duration_cast;
 using ::std::chrono::microseconds;
 using ::std::chrono::milliseconds;
diff --git a/google/cloud/bigtable/tests/filters_integration_test.cc b/google/cloud/bigtable/tests/filters_integration_test.cc
@@ -22,7 +22,7 @@ namespace bigtable {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::testing::ContainerEq;
 
 using FilterIntegrationTest =
diff --git a/google/cloud/bigtable/tests/mutations_integration_test.cc b/google/cloud/bigtable/tests/mutations_integration_test.cc
@@ -23,7 +23,7 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
 using ::google::cloud::testing_util::IsOk;
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 using ::testing::Not;
 
 using MutationIntegrationTest =
diff --git a/google/cloud/future_generic_test.cc b/google/cloud/future_generic_test.cc
@@ -23,7 +23,7 @@ namespace cloud {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 using ::testing::HasSubstr;
-using testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using testing_util::chrono_literals::operator""_ms;
 using testing_util::ExpectFutureError;
 using testing_util::ScopedThread;
 
diff --git a/google/cloud/future_generic_then_test.cc b/google/cloud/future_generic_then_test.cc
@@ -24,7 +24,7 @@ namespace cloud {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 using ::testing::HasSubstr;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::testing_util::ExpectFutureError;
 
 TEST(FutureTestInt, ThenSimple) {
diff --git a/google/cloud/future_void_test.cc b/google/cloud/future_void_test.cc
@@ -23,7 +23,7 @@ namespace cloud {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 using ::testing::HasSubstr;
-using testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using testing_util::chrono_literals::operator""_ms;
 using testing_util::ExpectFutureError;
 using testing_util::ScopedThread;
 
diff --git a/google/cloud/future_void_then_test.cc b/google/cloud/future_void_then_test.cc
@@ -24,7 +24,7 @@ namespace cloud {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 using ::testing::HasSubstr;
-using testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using testing_util::chrono_literals::operator""_ms;
 using testing_util::ExpectFutureError;
 
 TEST(FutureTestVoid, ThenSimple) {
diff --git a/google/cloud/internal/future_impl_test.cc b/google/cloud/internal/future_impl_test.cc
@@ -24,7 +24,7 @@ namespace internal {
 namespace {
 
 using ::testing::HasSubstr;
-using testing_util::chrono_literals::operator"" _us;  // NOLINT
+using testing_util::chrono_literals::operator""_us;
 using testing_util::ExpectFutureError;
 
 TEST(FutureImplInt, Basic) {
diff --git a/google/cloud/storage/parallel_uploads_test.cc b/google/cloud/storage/parallel_uploads_test.cc
@@ -46,7 +46,7 @@ namespace internal {
 namespace {
 
 using ::google::cloud::storage::testing::canonical_errors::PermanentError;
-using ::google::cloud::testing_util::chrono_literals::operator"" _ms;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_ms;
 using ::google::cloud::testing_util::IsOk;
 using ::google::cloud::testing_util::StatusIs;
 using ::testing::ElementsAre;
diff --git a/google/cloud/storage/tests/error_injection_integration_test.cc b/google/cloud/storage/tests/error_injection_integration_test.cc
@@ -33,7 +33,7 @@ namespace storage {
 GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_BEGIN
 namespace {
 
-using ::google::cloud::testing_util::chrono_literals::operator"" _us;  // NOLINT
+using ::google::cloud::testing_util::chrono_literals::operator""_us;
 using ::google::cloud::testing_util::IsOk;
 using ::google::cloud::testing_util::StatusIs;
 using ::testing::HasSubstr;
diff --git a/google/cloud/testing_util/chrono_literals.h b/google/cloud/testing_util/chrono_literals.h
@@ -25,32 +25,32 @@ namespace testing_util {
 namespace chrono_literals {
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::hours constexpr operator"" _h(unsigned long long h) {
+std::chrono::hours constexpr operator""_h(unsigned long long h) {
   return std::chrono::hours(h);
 }
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::minutes constexpr operator"" _min(unsigned long long m) {
+std::chrono::minutes constexpr operator""_min(unsigned long long m) {
   return std::chrono::minutes(m);
 }
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::seconds constexpr operator"" _s(unsigned long long s) {
+std::chrono::seconds constexpr operator""_s(unsigned long long s) {
   return std::chrono::seconds(s);
 }
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::milliseconds constexpr operator"" _ms(unsigned long long ms) {
+std::chrono::milliseconds constexpr operator""_ms(unsigned long long ms) {
   return std::chrono::milliseconds(ms);
 }
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::microseconds constexpr operator"" _us(unsigned long long us) {
+std::chrono::microseconds constexpr operator""_us(unsigned long long us) {
   return std::chrono::microseconds(us);
 }
 
 // NOLINTNEXTLINE(google-runtime-int)
-std::chrono::nanoseconds constexpr operator"" _ns(unsigned long long ns) {
+std::chrono::nanoseconds constexpr operator""_ns(unsigned long long ns) {
   return std::chrono::nanoseconds(ns);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ grpc::Status GrpcTransientError() {`
`43`	`43`	`return grpc::Status(grpc::StatusCode::UNAVAILABLE, "try again");`
`44`	`44`	`}`
`45`	`45`
`46`		`-using testing_util::chrono_literals::operator"" _ms; // NOLINT`
	`46`	`+using testing_util::chrono_literals::operator""_ms;`
`47`	`47`	`auto const kLimitedTimeTestPeriod = 100_ms;`
`48`	`48`	`auto const kLimitedTimeTolerance = 20_ms;`
`49`	`49`