Skip to content

Commit 41ea3fc

Browse files
authored
impl(bigtable): conf test fail on incomplete data (#15776)
1 parent 45a779e commit 41ea3fc

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

google/cloud/bigtable/ci/run_conformance_tests_proxy_bazel.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ exit_status=$?
5151
# CloseClient
5252
go test -v \
5353
-run "TestExecuteQuery|TestExecuteQuery_PlanRefresh$|TestExecuteQuery_PlanRefresh_WithMetadataChange|TestExecuteQuery_PlanRefresh_Retries|TestExecuteQuery_FailsOnSuccesfulStreamWithNoToken" \
54-
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows|FailsOnSuccesfulStreamWithNoToken|ChecksumMismatch|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
54+
-skip "CloseClient|FailsOnEmptyMetadata|FailsOnExecuteQueryMetadata|FailsOnInvalidType|ChecksumMismatch|FailsOnTypeMismatch|FailsOnTypeMismatchWithinMap|FailsOnTypeMismatchWithinArray|FailsOnTypeMismatchWithinStruct|FailsOnStructMissingField|TestExecuteQuery_PlanRefresh_AfterResumeTokenCausesError|TestExecuteQuery_RetryTest_WithPlanRefresh|TestExecuteQuery_PlanRefresh_RespectsDeadline|TestExecuteQuery_PlanRefresh_RecoversAfterPermanentError" \
5555
-proxy_addr=:9999
5656
exit_status=$?
5757

@@ -67,7 +67,7 @@ exit_status=$?
6767

6868
# Stream reading tests b/461232110
6969
#go test -v \
70-
# -run "FailsOnNotEnoughData|FailsOnNotEnoughDataWithCompleteRows|ChecksumMismatch" \
70+
# -run "ChecksumMismatch" \
7171
# -proxy_addr=:9999
7272
#exit_status=$?
7373

@@ -79,7 +79,7 @@ exit_status=$?
7979

8080
# QueryPlan refresh tests b/461233613
8181
#go test -v \
82-
# -run "RetryTest_WithPlanRefresh|PlanRefresh" \
82+
# -run "RetryTest_WithPlanRefresh|PlanRefresh|PlanRefresh_RecoversAfterPermanentError" \
8383
# -proxy_addr=:9999
8484
#exit_status=$?
8585

google/cloud/bigtable/internal/partial_result_set_source.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,10 @@ Status PartialResultSetSource::BufferProtoRows() {
215215
GCP_ERROR_INFO());
216216
}
217217
if (proto_values.size() % columns_size != 0) {
218+
state_ = State::kFinished;
218219
return internal::InternalError(
219220
"The number of values in ProtoRows is not a multiple of the "
220-
"number of columns in the schema.",
221+
"number of columns in the schema or received incomplete row",
221222
GCP_ERROR_INFO());
222223
}
223224

0 commit comments

Comments
 (0)