fix: fix 1000+ buckets pagination issue

eliekozah · eliekozah · commit 441eeb25c998 · 2025-04-28T16:18:46.000Z
diff --git a/google/cloud/storage/internal/rest/stub.cc b/google/cloud/storage/internal/rest/stub.cc
@@ -183,6 +183,7 @@ StatusOr<ListBucketsResponse> RestStub::ListBuckets(
   if (!headers.ok()) return headers;
   request.AddOptionsToHttpRequest(builder);
   builder.AddQueryParameter("project", request.project_id());
+  builder.AddQueryParameter("pageToken", request.page_token());
   return ParseFromRestResponse<ListBucketsResponse>(
       storage_rest_client_->Get(context, std::move(builder).BuildRequest()));
 }

Original file line number	Diff line number	Diff line change
`@@ -183,6 +183,7 @@ StatusOr<ListBucketsResponse> RestStub::ListBuckets(`
`183`	`183`	`if (!headers.ok()) return headers;`
`184`	`184`	`request.AddOptionsToHttpRequest(builder);`
`185`	`185`	`builder.AddQueryParameter("project", request.project_id());`
	`186`	`+ builder.AddQueryParameter("pageToken", request.page_token());`
`186`	`187`	`return ParseFromRestResponse<ListBucketsResponse>(`
`187`	`188`	`storage_rest_client_->Get(context, std::move(builder).BuildRequest()));`
`188`	`189`	`}`