Skip to content

Commit 533552f

Browse files
committed
run checker
1 parent 2025d70 commit 533552f

18 files changed

+15
-54
lines changed

google/cloud/google_cloud_cpp_common.cmake

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,7 @@ if (opentelemetry IN_LIST GOOGLE_CLOUD_CPP_ENABLE)
202202
if (opentelemetry-cpp_FOUND)
203203
target_link_libraries(google_cloud_cpp_common
204204
PUBLIC opentelemetry-cpp::api)
205-
target_compile_definitions(
206-
google_cloud_cpp_common)
205+
target_compile_definitions(google_cloud_cpp_common)
207206
set(GOOGLE_CLOUD_CPP_FIND_OPTIONAL_DEPENDENCIES
208207
"find_dependency(opentelemetry-cpp)")
209208
set(GOOGLE_CLOUD_CPP_OPENTELEMETRY_API "opentelemetry_api")

google/cloud/internal/async_read_write_stream_tracing_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,4 +388,4 @@ TEST(AsyncStreamingReadWriteRpcTracing, StartedStreamShouldExtractMetadata) {
388388
} // namespace internal
389389
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
390390
} // namespace cloud
391-
} // namespace google
391+
} // namespace google

google/cloud/internal/async_streaming_read_rpc_tracing_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,4 +264,4 @@ TEST(AsyncStreamingReadRpcTracing, StartedStreamShouldExtractMetadata) {
264264
} // namespace internal
265265
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
266266
} // namespace cloud
267-
} // namespace google
267+
} // namespace google

google/cloud/internal/opentelemetry.h

Lines changed: 0 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -263,37 +263,3 @@ GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
263263
} // namespace google
264264

265265
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_OPENTELEMETRY_H
266-
267-
bool TracingEnabled(Options const& options);
268-
269-
/// Wraps the sleeper in a span, if tracing is enabled.
270-
template <typename Rep, typename Period>
271-
std::function<void(std::chrono::duration<Rep, Period>)> MakeTracedSleeper(
272-
Options const& options,
273-
std::function<void(std::chrono::duration<Rep, Period>)> sleeper,
274-
std::string const& name) {
275-
if (TracingEnabled(options)) {
276-
return [name, sleeper = std::move(sleeper)](
277-
std::chrono::duration<Rep, Period> d) {
278-
// A sleep of 0 is not an interesting event worth tracing.
279-
if (d == std::chrono::duration<Rep, Period>::zero()) return sleeper(d);
280-
auto span = MakeSpan(name);
281-
sleeper(d);
282-
span->End();
283-
};
284-
}
285-
(void)options;
286-
(void)name;
287-
return sleeper;
288-
}
289-
290-
/// Adds an attribute to the active span, if tracing is enabled.
291-
void AddSpanAttribute(Options const& options, std::string const& key,
292-
std::string const& value);
293-
294-
} // namespace internal
295-
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
296-
} // namespace cloud
297-
} // namespace google
298-
299-
#endif // GOOGLE_CLOUD_CPP_GOOGLE_CLOUD_INTERNAL_OPENTELEMETRY_H

google/cloud/internal/trace_propagator.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,4 +102,4 @@ MakePropagator() {
102102
} // namespace internal
103103
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
104104
} // namespace cloud
105-
} // namespace google
105+
} // namespace google

google/cloud/internal/trace_propagator_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,4 +112,4 @@ TEST(CloudTraceContextPropagator, Fields) {
112112
} // namespace internal
113113
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
114114
} // namespace cloud
115-
} // namespace google
115+
} // namespace google

google/cloud/internal/traced_stream_range_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,4 +127,4 @@ TEST(TracedStreamRange, SpanInactiveWhileIterating) {
127127
} // namespace internal
128128
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
129129
} // namespace cloud
130-
} // namespace google
130+
} // namespace google

google/cloud/internal/tracing_rest_client.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,4 +246,4 @@ std::unique_ptr<RestClient> MakeTracingRestClient(
246246
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
247247
} // namespace rest_internal
248248
} // namespace cloud
249-
} // namespace google
249+
} // namespace google

google/cloud/opentelemetry/integration_tests/configure_basic_tracing_integration_test.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,4 +158,4 @@ TEST(ConfigureBasicTracing, RestoresPrevious) {
158158
GOOGLE_CLOUD_CPP_INLINE_NAMESPACE_END
159159
} // namespace otel
160160
} // namespace cloud
161-
} // namespace google
161+
} // namespace google

google/cloud/pubsub/integration_tests/blocking_publisher_integration_test.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,6 @@ TEST_F(BlockingPublisherIntegrationTest, Basic) {
7171
ASSERT_STATUS_OK(publish);
7272
}
7373

74-
7574
using ::google::cloud::testing_util::DisableTracing;
7675
using ::google::cloud::testing_util::EnableTracing;
7776

0 commit comments

Comments
 (0)