feat(storagecontrol): declare GA (#13988)

Author: coryan

CHANGELOG.md

@@ -14,6 +14,7 @@ the APIs in these libraries are stable, and are ready for production use.
 - [App Hub API](/google/cloud/apphub/README.md)
 - [Backup and DR Service API](/google/cloud/backupdr/README.md)
 - [Sovereign Controls by Partners](/google/cloud/cloudcontrolspartner/README.md)
+- [Cloud Storage Control API](/google/cloud/storagecontrol/README.md) is now GA.
 
 ### Updated Libraries
 

README.md

@@ -415,6 +415,9 @@ See each library's `README.md` file for more information about:
 - [Google Cloud Storage](google/cloud/storage/README.md)
   [\[quickstart\]](google/cloud/storage/quickstart/README.md)
   [\[reference\]](https://cloud.google.com/cpp/docs/reference/storage/latest)
+- [Cloud Storage Control API](google/cloud/storagecontrol/README.md)
+  [\[quickstart\]](google/cloud/storagecontrol/quickstart/README.md)
+  [\[reference\]](https://cloud.google.com/cpp/docs/reference/storagecontrol/latest)
 - [Storage Insights API](google/cloud/storageinsights/README.md)
   [\[quickstart\]](google/cloud/storageinsights/quickstart/README.md)
   [\[reference\]](https://cloud.google.com/cpp/docs/reference/storageinsights/latest)

ci/abi-dumps/google_cloud_cpp_storagecontrol.expected.abi.dump.gz

@@ -34,10 +34,10 @@ set(GOOGLE_CLOUD_CPP_NO_GRPC_FEATURES
 set(GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES
     # cmake-format: sort
     "pubsublite" # This is WIP, it needs a number of hand-crafted APIs.
-    "storagecontrol")
+)
 
 set(GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES # cmake-format: sort
-)
+                                          "storagecontrol")
 
 set(GOOGLE_CLOUD_CPP_GA_LIBRARIES
     # cmake-format: sort

cmake/GoogleCloudCppFeatures.cmake

@@ -3351,7 +3351,6 @@ service {
     "kInternal",
     "kUnknown"
   ]
-  omit_repo_metadata: true
   idempotency_overrides: [
     {rpc_name: "StorageControl.GetFolder", idempotency: IDEMPOTENT},
     {rpc_name: "StorageControl.ListFolders", idempotency: IDEMPOTENT},

generator/generator_config.textproto

@@ -16,13 +16,13 @@
 
 include(GoogleCloudCppLibrary)
 
-google_cloud_cpp_add_gapic_library(storagecontrol "Cloud Storage API"
-                                   EXPERIMENTAL SERVICE_DIRS "v2/")
+google_cloud_cpp_add_gapic_library(storagecontrol "Cloud Storage API" TRANSITION
+                                   SERVICE_DIRS "v2/")
 
 if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
     add_executable(storagecontrol_quickstart "quickstart/quickstart.cc")
     target_link_libraries(storagecontrol_quickstart
-                          PRIVATE google-cloud-cpp::experimental-storagecontrol)
+                          PRIVATE google-cloud-cpp::storagecontrol)
     google_cloud_cpp_add_common_options(storagecontrol_quickstart)
     add_test(
         NAME storagecontrol_quickstart

google/cloud/storagecontrol/CMakeLists.txt

@@ -1,15 +1,11 @@
 # Cloud Storage Control API C++ Client Library
 
-:construction:
-
 This directory contains an idiomatic C++ client library for the
 [Cloud Storage Control API][cloud-service-docs], a service to manage GCS
 configuration.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
-[Semantic Versioning](https://semver.org/).
+While this library is **GA**, please note that the Google Cloud C++ client
+libraries do **not** follow [Semantic Versioning](https://semver.org/).
 
 ## Quickstart
 

google/cloud/storagecontrol/README.md

@@ -5,9 +5,8 @@
 An idiomatic C++ client library for the [Cloud Storage Control API][cloud-service-docs], a service
 to Lets you store and retrieve potentially-large, immutable data objects.
 
-This library is **experimental**. Its APIs are subject to change without notice.
-
-Please, note that the Google Cloud C++ client libraries do **not** follow
+While this library is **GA**, please note that the Google Cloud C++ client
+libraries do **not** follow [Semantic Versioning](https://semver.org/).
 [Semantic Versioning](https://semver.org/).
 
 @tableofcontents{HTML:2}

google/cloud/storagecontrol/doc/main.dox

@@ -8,7 +8,7 @@
     "library_type": "GAPIC_AUTO",
     "name_pretty": "Cloud Storage API",
     "product_documentation": "https://cloud.google.com/storage/docs/overview",
-    "release_level": "preview",
+    "release_level": "stable",
     "repo": "googleapis/google-cloud-cpp",
     "requires_billing": true
 }

google/cloud/storagecontrol/v2/.repo-metadata.json

@@ -18,10 +18,10 @@
 
 GOOGLE_CLOUD_CPP_EXPERIMENTAL_LIBRARIES = [
     "pubsublite",
-    "storagecontrol",
 ]
 
 GOOGLE_CLOUD_CPP_TRANSITION_LIBRARIES = [
+    "storagecontrol",
 ]
 
 GOOGLE_CLOUD_CPP_GA_LIBRARIES = [