Skip to content

Commit 5bf1291

Browse files
committed
plumb env var through
1 parent f2da687 commit 5bf1291

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

ci/cloudbuild/builds/lib/integration.sh

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,9 @@ function integration::bazel_args() {
8484
"--test_env=GOOGLE_CLOUD_CPP_BIGTABLE_TEST_SERVICE_ACCOUNT=${GOOGLE_CLOUD_CPP_BIGTABLE_TEST_SERVICE_ACCOUNT}"
8585
"--test_env=ENABLE_BIGTABLE_ADMIN_INTEGRATION_TESTS=${ENABLE_BIGTABLE_ADMIN_INTEGRATION_TESTS:-no}"
8686

87+
# Pubsub
88+
"--test_env=GOOGLE_CLOUD_CPP_PUBSUB_TEST_IMPERSONATED_SERVICE_ACCOUNT=${GOOGLE_CLOUD_CPP_PUBSUB_TEST_IMPERSONATED_SERVICE_ACCOUNT}"
89+
8790
# Rest
8891
"--test_env=GOOGLE_CLOUD_CPP_REST_TEST_SIGNING_SERVICE_ACCOUNT=${GOOGLE_CLOUD_CPP_REST_TEST_SIGNING_SERVICE_ACCOUNT}"
8992

google/cloud/pubsub/integration_tests/subscriber_integration_test.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,6 @@ TEST_F(SubscriberIntegrationTest, PublishPullAckWithImpersonatedCredentials) {
356356
google::cloud::internal::GetEnv(
357357
"GOOGLE_CLOUD_CPP_PUBSUB_TEST_IMPERSONATED_SERVICE_ACCOUNT")
358358
.value_or("");
359-
if (iam_service_account.empty()) GTEST_SKIP();
360359
auto google_default_credentials = MakeGoogleDefaultCredentials();
361360
auto options = Options{}.set<UnifiedCredentialsOption>(
362361
MakeImpersonateServiceAccountCredentials(google_default_credentials,

0 commit comments

Comments
 (0)