Skip to content

Commit 5e8474a

Browse files
authored
ci: enable global and add non-us region to speech quickstart (#14848)
1 parent 000bb23 commit 5e8474a

File tree

3 files changed

+21
-11
lines changed

3 files changed

+21
-11
lines changed

ci/cloudbuild/builds/lib/integration.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ function integration::bazel_args() {
5757
# Common settings
5858
"--test_env=GOOGLE_CLOUD_PROJECT=${GOOGLE_CLOUD_PROJECT}"
5959
"--test_env=GOOGLE_CLOUD_CPP_TEST_REGION=${GOOGLE_CLOUD_CPP_TEST_REGION}"
60+
"--test_env=GOOGLE_CLOUD_CPP_NON_US_TEST_REGION=${GOOGLE_CLOUD_CPP_NON_US_TEST_REGION}"
6061
"--test_env=GOOGLE_CLOUD_CPP_TEST_ZONE=${GOOGLE_CLOUD_CPP_TEST_ZONE}"
6162
"--test_env=GOOGLE_CLOUD_CPP_TEST_ORGANIZATION=${GOOGLE_CLOUD_CPP_TEST_ORGANIZATION}"
6263
"--test_env=GOOGLE_CLOUD_CPP_TEST_SERVICE_ACCOUNT_KEYFILE=${GOOGLE_CLOUD_CPP_TEST_SERVICE_ACCOUNT_KEYFILE}"

ci/etc/integration-tests-config.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,8 @@ export GOOGLE_CLOUD_CPP_USER_PROJECT="${GOOGLE_CLOUD_PROJECT}"
3434
export GOOGLE_CLOUD_CPP_TEST_REGION="us-central1"
3535
# Some quickstart programs require a zone.
3636
export GOOGLE_CLOUD_CPP_TEST_ZONE="us-central1-a"
37+
# Some tests and quickstarts benefit from a region outside the US.
38+
export GOOGLE_CLOUD_CPP_NON_US_TEST_REGION="asia-southeast1"
3739
# Some tests and quickstarts need to specify a location as "global".
3840
export GOOGLE_CLOUD_CPP_TEST_GLOBAL="global"
3941
# Some quickstart programs require an organization.

google/cloud/speech/CMakeLists.txt

Lines changed: 18 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -25,21 +25,28 @@ if (BUILD_TESTING AND GOOGLE_CLOUD_CPP_ENABLE_CXX_EXCEPTIONS)
2525
add_executable(speech_quickstart "quickstart/quickstart.cc")
2626
target_link_libraries(speech_quickstart PRIVATE google-cloud-cpp::speech)
2727
google_cloud_cpp_add_common_options(speech_quickstart)
28-
# TODO(#14841): add this back when the test on CI is recovered.
29-
30-
# add_test( NAME speech_quickstart_global COMMAND cmake -P
31-
# "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
32-
# $<TARGET_FILE:speech_quickstart> GOOGLE_CLOUD_PROJECT
33-
# GOOGLE_CLOUD_CPP_TEST_GLOBAL)
34-
# set_tests_properties(speech_quickstart_global PROPERTIES LABELS
35-
# "integration-test;quickstart")
3628
add_test(
37-
NAME speech_quickstart_regional
29+
NAME speech_quickstart_global
30+
COMMAND
31+
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
32+
$<TARGET_FILE:speech_quickstart> GOOGLE_CLOUD_PROJECT
33+
GOOGLE_CLOUD_CPP_TEST_GLOBAL)
34+
set_tests_properties(speech_quickstart_global
35+
PROPERTIES LABELS "integration-test;quickstart")
36+
add_test(
37+
NAME speech_quickstart_us_regional
3838
COMMAND
3939
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
4040
$<TARGET_FILE:speech_quickstart> GOOGLE_CLOUD_PROJECT
4141
GOOGLE_CLOUD_CPP_TEST_REGION)
42-
set_tests_properties(speech_quickstart_regional
42+
set_tests_properties(speech_quickstart_us_regional
43+
PROPERTIES LABELS "integration-test;quickstart")
44+
add_test(
45+
NAME speech_quickstart_non_us_regional
46+
COMMAND
47+
cmake -P "${PROJECT_SOURCE_DIR}/cmake/quickstart-runner.cmake"
48+
$<TARGET_FILE:speech_quickstart> GOOGLE_CLOUD_PROJECT
49+
GOOGLE_CLOUD_CPP_NON_US_TEST_REGION)
50+
set_tests_properties(speech_quickstart_non_us_regional
4351
PROPERTIES LABELS "integration-test;quickstart")
44-
4552
endif ()

0 commit comments

Comments
 (0)