Skip to content

Commit 77cbe79

Browse files
authored
ci: update cmake quickstart handling for storage grpc (#14856)
1 parent bb5800b commit 77cbe79

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

ci/cloudbuild/builds/cmake-install.sh

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -213,25 +213,17 @@ io::log_h1 "Build and run quickstarts"
213213
# Tests the installed artifacts by building and running the quickstarts.
214214
# shellcheck disable=SC2046
215215
feature_list="$(printf "%s;" $(features::libraries))"
216-
# GCS+gRPC and OpenTelemetry also have quickstarts.
216+
# OpenTelemetry also has a quickstart.
217217
feature_list="${feature_list}opentelemetry"
218218

219-
io::log_h2 "Most features"
219+
io::log_h2 "All features"
220220
cmake -G Ninja \
221221
-S "${PROJECT_ROOT}/ci/verify_quickstart" \
222222
-B "${PROJECT_ROOT}/cmake-out/quickstart" \
223223
"-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX}" \
224224
"-DFEATURES=${feature_list}"
225225
cmake --build "${PROJECT_ROOT}/cmake-out/quickstart"
226226

227-
io::log_h2 "GCS+gRPC"
228-
cmake -G Ninja \
229-
-S "${PROJECT_ROOT}/ci/verify_quickstart" \
230-
-B "${PROJECT_ROOT}/cmake-out/quickstart" \
231-
"-DCMAKE_PREFIX_PATH=${INSTALL_PREFIX}" \
232-
"-DFEATURES=storage_grpc"
233-
cmake --build "${PROJECT_ROOT}/cmake-out/quickstart"
234-
235227
io::log_h2 "Delete installed artifacts and run compiled quickstarts"
236228
# Deletes all the installed artifacts, and installs only the runtime components
237229
# to verify that we can still execute the compiled quickstart programs.

ci/verify_quickstart/CMakeLists.txt

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,11 @@ function (add_make_quickstart_target feature library target)
100100
endfunction ()
101101

102102
foreach (feature IN LISTS FEATURES)
103-
if ("${feature}" STREQUAL "storage_grpc")
103+
# Regardless of whether "-" or "_" is used for storage+grpc, its quickstart
104+
# does not follow the usual convention for feature to quickstart naming nor
105+
# location.
106+
if ("${feature}" STREQUAL "storage-grpc" OR "${feature}" STREQUAL
107+
"storage_grpc")
104108
add_cmake_quickstart_target("${feature}" storage quickstart_grpc)
105109
add_make_quickstart_target("${feature}" storage quickstart_grpc)
106110
continue()

0 commit comments

Comments
 (0)