update build rules to include universe_domain lib when building samples

Author: scotthart

bazel/gapic.bzl

@@ -82,6 +82,7 @@ def cc_gapic_library(name, service_dirs = [], googleapis_deps = [], additional_d
         tags = ["integration-test"],
         deps = [
             "//:" + name,
+            "//:experimental-universe_domain",
             "//google/cloud/testing_util:google_cloud_cpp_testing_private",
         ],
     ) for sample in native.glob([d + "samples/*_samples.cc" for d in service_dirs])]

ci/cloudbuild/builds/lib/features.sh

@@ -42,6 +42,8 @@ function features::always_build() {
     opentelemetry
     # Enable storage_grpc in most builds.
     storage_grpc
+    # Samples require universe domain support.
+    universe_domain
   )
   printf "%s\n" "${list[@]}" | sort -u
 }

ci/lib/shard.sh

@@ -36,11 +36,13 @@ readonly DEFAULT_SHARD=(
   bigtable
   spanner
   logging
+  universe_domain
 )
 
 readonly BIGQUERY_SHARD=(
   bigquery
   experimental-bigquery_rest
+  universe_domain
 )
 
 readonly PUBSUB_SHARD=(
@@ -51,6 +53,7 @@ readonly PUBSUB_SHARD=(
   # IAM is included because it has hand-crafted tests and/or examples and is
   # required by Pub/Sub
   iam
+  universe_domain
 )
 
 readonly STORAGE_SHARD=(

cmake/GoogleCloudCppCommon.cmake

@@ -132,12 +132,16 @@ function (google_cloud_cpp_add_samples_relative library path)
         google_cloud_cpp_add_executable(target "${library}" "${source}")
         if (TARGET google-cloud-cpp::${library})
             target_link_libraries(
-                "${target}" PRIVATE google-cloud-cpp::${library}
-                                    google_cloud_cpp_testing)
+                "${target}"
+                PRIVATE google-cloud-cpp::${library}
+                        google-cloud-cpp::universe_domain
+                        google_cloud_cpp_testing)
         elseif (TARGET google-cloud-cpp::experimental-${library})
             target_link_libraries(
-                "${target}" PRIVATE google-cloud-cpp::experimental-${library}
-                                    google_cloud_cpp_testing)
+                "${target}"
+                PRIVATE google-cloud-cpp::experimental-${library}
+                        google-cloud-cpp::universe_domain
+                        google_cloud_cpp_testing)
         endif ()
         google_cloud_cpp_add_common_options("${target}")
         add_test(NAME "${target}" COMMAND "${target}")