Skip to content

Commit 8111d9f

Browse files
committed
additional clean up
1 parent 9d3526d commit 8111d9f

File tree

2 files changed

+2
-17
lines changed

2 files changed

+2
-17
lines changed

google/cloud/storage/client.h

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3603,20 +3603,8 @@ struct ClientImplDetails {
36033603
// NOLINTNEXTLINE(performance-unnecessary-value-param)
36043604
static Client CreateClient(std::shared_ptr<StorageConnection> c,
36053605
Policies&&... p) {
3606-
struct ApplyPoliciesHelper {
3607-
Options& opts;
3608-
void operator()(RetryPolicy const& p) {
3609-
opts.set<RetryPolicyOption>(p.clone());
3610-
}
3611-
void operator()(BackoffPolicy const& p) {
3612-
opts.set<BackoffPolicyOption>(p.clone());
3613-
}
3614-
void operator()(IdempotencyPolicy const& p) {
3615-
opts.set<IdempotencyPolicyOption>(p.clone());
3616-
}
3617-
};
3618-
auto opts = c->options();
3619-
(ApplyPoliciesHelper{opts}(std::forward<Policies>(p)), ...);
3606+
auto opts =
3607+
internal::ApplyPolicies(c->options(), std::forward<Policies>(p)...);
36203608
return CreateWithDecorations(opts, std::move(c));
36213609
}
36223610
};

google/cloud/storage/tests/object_media_integration_test.cc

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -515,9 +515,6 @@ TEST_F(ObjectMediaIntegrationTest, ConnectionFailureUploadFile) {
515515
TEST_F(ObjectMediaIntegrationTest, StreamingReadTimeout) {
516516
// The emulator does not support this type of fault injection for gRPC.
517517
if (!UsingEmulator() || UsingGrpc()) GTEST_SKIP();
518-
// auto options = internal::DefaultOptions();
519-
// ASSERT_STATUS_OK(options);
520-
521518
auto client = MakeIntegrationTestClient(
522519
Options{}
523520
.set<TransferStallTimeoutOption>(std::chrono::seconds(3))

0 commit comments

Comments
 (0)