Skip to content

Commit 81dae98

Browse files
committed
chore: use Bytes key
1 parent 32bb501 commit 81dae98

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

google/cloud/bigtable/tests/data_integration_test.cc

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -668,10 +668,9 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamily) {
668668
auto const& row1 = *rows[0];
669669
ASSERT_EQ(row1.columns().size(), 1);
670670
ASSERT_EQ(row1.columns().at(0), family);
671-
ASSERT_EQ(
672-
row1.values().at(0),
673-
Value(std::unordered_map<std::string, std::string>{
674-
{R"val(c1)val", R"val(v1)val"}, {R"val(c2)val", R"val(v2)val"}}));
671+
ASSERT_EQ(row1.values().at(0), Value(std::unordered_map<Bytes, Bytes>{
672+
{Bytes(column1), Bytes(value1)},
673+
{Bytes(column2), Bytes(value2)}}));
675674
}
676675

677676
TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
@@ -762,7 +761,6 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
762761
auto value_hist = row.get("family4_history");
763762
ASSERT_TRUE(value_hist.ok()) << value_hist.status().message();
764763
Value const& bigtable_val = *value_hist;
765-
std::cout << bigtable_val << std::endl;
766764
using HistoryEntry = std::tuple<std::pair<std::string, Timestamp>,
767765
std::pair<std::string, Bytes>>;
768766
auto history_map =
@@ -771,7 +769,7 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
771769
ASSERT_EQ(history_map->size(), 2);
772770

773771
// Verify the new version of "c1"
774-
auto c1_entry0 = (*history_map)[Bytes("c1")][0];
772+
auto c1_entry0 = (*history_map)[Bytes(column1)][0];
775773
auto c1_ts_new =
776774
std::get<0>(c1_entry0).second.get<sys_time<std::chrono::microseconds>>();
777775
ASSERT_STATUS_OK(c1_ts_new);
@@ -783,7 +781,7 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
783781
column_1_value_new);
784782

785783
// Verify the old version of "c1"
786-
auto c1_entry1 = (*history_map)[Bytes("c1")][1];
784+
auto c1_entry1 = (*history_map)[Bytes(column1)][1];
787785
auto c1_ts_old =
788786
std::get<0>(c1_entry1).second.get<sys_time<std::chrono::microseconds>>();
789787
ASSERT_STATUS_OK(c1_ts_old);
@@ -795,7 +793,7 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
795793
column_1_value_new);
796794

797795
// Verify the new version of "c2"
798-
auto c2_entry0 = (*history_map)[Bytes("c2")][0];
796+
auto c2_entry0 = (*history_map)[Bytes(column2)][0];
799797
auto c2_ts_new =
800798
std::get<0>(c2_entry0).second.get<sys_time<std::chrono::microseconds>>();
801799
ASSERT_STATUS_OK(c2_ts_new);
@@ -807,7 +805,7 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
807805
column_2_value_new);
808806

809807
// Verify the old version of "c2"
810-
auto c2_entry1 = (*history_map)[Bytes("c2")][1];
808+
auto c2_entry1 = (*history_map)[Bytes(column2)][1];
811809
auto c2_ts_old =
812810
std::get<0>(c2_entry1).second.get<sys_time<std::chrono::microseconds>>();
813811
ASSERT_STATUS_OK(c2_ts_old);
@@ -816,7 +814,7 @@ TEST_P(DataIntegrationTest, ClientQueryColumnFamilyWithHistory) {
816814
EXPECT_EQ(duration_cast<milliseconds>(c2_ts_old->time_since_epoch()),
817815
c2_expected_old_time_ms);
818816
EXPECT_EQ(std::get<1>(c2_entry1).second.get<std::string>(),
819-
column_2_value_new);
817+
column_2_value_old);
820818
}
821819

822820
// TODO(#8800) - remove after deprecation is complete

0 commit comments

Comments
 (0)