Skip to content

Commit 85c677c

Browse files
committed
simplify tests
1 parent 731006a commit 85c677c

File tree

2 files changed

+12
-17
lines changed

2 files changed

+12
-17
lines changed

google/cloud/bigtable/internal/data_connection_impl.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -930,7 +930,6 @@ bigtable::RowStream DataConnectionImpl::ExecuteQuery(
930930
request.instance_name(), app_profile_id(*current));
931931

932932
auto query_plan = params.bound_query.query_plan_;
933-
934933
auto query_plan_retry_policy = query_plan_refresh_retry_policy(*current);
935934
auto query_plan_backoff_policy = backoff_policy(*current);
936935
Status last_status;
@@ -967,7 +966,6 @@ bigtable::RowStream DataConnectionImpl::ExecuteQuery(
967966
return bigtable::RowStream(std::make_unique<StatusOnlyResultSetSource>(
968967
std::move(last_status)));
969968
}
970-
971969
} else {
972970
last_status = query_plan_data.status();
973971
}

google/cloud/bigtable/internal/data_connection_impl_test.cc

Lines changed: 12 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3720,21 +3720,18 @@ TEST_F(DataConnectionTest, ExecuteQueryFailureWithSchemaChange) {
37203720
Status{StatusCode::kUnimplemented, "not implemented"}));
37213721
};
37223722
EXPECT_CALL(*mock, ExecuteQuery)
3723-
.Times(1)
3724-
.WillRepeatedly(
3725-
[&](auto, auto const&,
3726-
google::bigtable::v2::ExecuteQueryRequest const& request) {
3727-
EXPECT_EQ(request.app_profile_id(), kAppProfile);
3728-
EXPECT_EQ(request.instance_name(),
3729-
"projects/test-project/instances/test-instance");
3730-
auto stream = std::make_unique<MockExecuteQueryStream>();
3731-
EXPECT_CALL(*stream, Read)
3732-
.WillOnce([&](google::bigtable::v2::ExecuteQueryResponse* r) {
3733-
*r = eq_response;
3734-
return absl::nullopt;
3735-
});
3736-
return stream;
3737-
});
3723+
.WillOnce([&](auto, auto const&,
3724+
google::bigtable::v2::ExecuteQueryRequest const& request) {
3725+
EXPECT_EQ(request.instance_name(),
3726+
"projects/test-project/instances/test-instance");
3727+
auto stream = std::make_unique<MockExecuteQueryStream>();
3728+
EXPECT_CALL(*stream, Read)
3729+
.WillOnce([&](google::bigtable::v2::ExecuteQueryResponse* r) {
3730+
*r = eq_response;
3731+
return absl::nullopt;
3732+
});
3733+
return stream;
3734+
});
37383735

37393736
auto conn = TestConnection(std::move(mock), std::move(factory));
37403737
internal::OptionsSpan span(CallOptions());

0 commit comments

Comments
 (0)